AdGuardHome icon indicating copy to clipboard operation
AdGuardHome copied to clipboard

Crashing when updating filters

Open neil-microsoft opened this issue 1 year ago • 11 comments

Prerequisites

Platform (OS and CPU architecture)

Linux, ARMv5

Installation

Other (please mention in the description)

Setup

Other (please mention in the description)

AdGuard Home version

Raspberry Pi

Action

from the UI, i went to filters, then looked at the filter lists. when going out and back to dashboard, site is unresponsive and add blcoking stops. i have to unplug it to get it back working. If i dont go to filters, no issues.

Expected result

Filter vieweing should not crash the software

Actual result

crashes the ui and the ip becomes unresponsive

Additional information and/or screenshots

No response

neil-microsoft avatar Aug 07 '24 16:08 neil-microsoft

2024-08-07_09h39_44

neil-microsoft avatar Aug 07 '24 16:08 neil-microsoft

Check the verbose logs for the precise errors and make sure you aren't adding too many rules for your machine.

ainar-g avatar Aug 08 '24 10:08 ainar-g

Check the verbose logs for the precise errors and make sure you aren't adding too many rules for your machine.

@ainar-g I've also experienced this issue yesterday, unblocked 4 entries on the Query Log, and it crashed my internet. Can you be more specific when you say: "make sure you aren't adding too many rules for your machine.". Two reboots and one power off after it all went back working again, no logs after.

chapas avatar Aug 08 '24 11:08 chapas

The most CPU- and RAM-intensive task in AdGuard Home is the filtering engine compilation, and depending on how much CPU power and RAM the machine has, there are limits to what is a reasonable number. For general protection, enabling lists with ≤ 1M rules should be enough.

As mentioned, the verbose logs are the most direct way to see if this is related to the filtering engine or not.

ainar-g avatar Aug 08 '24 12:08 ainar-g

This is exactly the issue. Glad it isn’t just me. Exactly the issue. Sent from a mobile device. Please excuse typographical errors. On Aug 8, 2024, at 4:53 AM, chapas @.> wrote:Re: [AdguardTeam/AdGuardHome] Crashing when updating filters (Issue #7174)Check the verbose logs for the precise errors and make sure you aren't adding too many rules for your @.'ve also experienced this issue yesterday, unblocked 4 entries on the Query Log, and it crashed my internet. Can you be more specific when you say: "make sure you aren't adding too many rules for your machine.".Two reboots and one power off after it all went back working again, no logs after.—Reply to this email directly, view it on GitHub or unsubscribe.You are receiving this email because you commented on the thread.Triage notifications on the go with GitHub Mobile for iOS or Android.                                                           

neil-microsoft avatar Aug 08 '24 15:08 neil-microsoft

I don’t think I have any lists other than the default ones. Sent from a mobile device. Please excuse typographical errors. On Aug 8, 2024, at 5:16 AM, Ainar Garipov @.***> wrote:Re: [AdguardTeam/AdGuardHome] Crashing when updating filters (Issue #7174)The most CPU- and RAM-intensive task in AdGuard Home is the filtering engine compilation, and depending on how much CPU power and RAM the machine has, there are limits to what is a reasonable number. For general protection, enabling lists with ≤ 1M rules should be enough.As mentioned, the verbose logs are the most direct way to see if this is related to the filtering engine or not.—Reply to this email directly, view it on GitHub or unsubscribe.You are receiving this email because you authored the thread.Triage notifications on the go with GitHub Mobile for iOS or Android.                                                           

neil-microsoft avatar Aug 08 '24 15:08 neil-microsoft

I have added all active rules and the total across 14 rulesets totals 547,901, so not near a 1m cap.

neil-microsoft avatar Aug 08 '24 19:08 neil-microsoft

I have the log files and can DM them. dont want to post here for everyone

neil-microsoft avatar Aug 08 '24 19:08 neil-microsoft

i was able to repro by navigating to client settings, clicking apply in the first section and then navigating away. And once it crashes, I have to unplug of SSH into the device and force stop and restart the adguard service

neil-microsoft avatar Aug 08 '24 19:08 neil-microsoft

and then i receive this from the log page. 2024-08-08_12h12_28 2024-08-08_12h13_11

neil-microsoft avatar Aug 08 '24 19:08 neil-microsoft

This is crashing more and more now.

neil-microsoft avatar Aug 09 '24 22:08 neil-microsoft

...same here on my second agh. 1st one working fine, no probs 2nd with the issue u descrieb. Saw somwhere "expected permissions" in log but changing didnt solve the problem. Let me know if u solved the problem.

Sudden7503 avatar Dec 20 '24 09:12 Sudden7503

(I am using AGH on OpenWrt).

As a hopefully temporary solution, I am using this cronjob to restart AGH after a crash (the check is done every minutes, and requires jq):

# Restart AdGuard Home on crash
* * * * * [ "$(service adguardhome info | jq '.adguardhome.instances.instance1.running')" = "true" ] || service adguardhome start

BoboTiG avatar Dec 27 '24 18:12 BoboTiG

Glad i found the Error on my System the last days. My VPS just had 1G ram and afterwards i recognized theres no swap installed. So when updating this huge amount of lists, the System freezed when ram was full. After changing swappiness and installing a swapfile, System works perfect. Hope this helps maybe for understanding.

Sudden7503 avatar Dec 27 '24 18:12 Sudden7503