AdGuardHome icon indicating copy to clipboard operation
AdGuardHome copied to clipboard

Wildcard $dnsrewrite interfering with non-wildcard $dnsrewrite

Open ruifung opened this issue 1 year ago • 13 comments

Prerequisites

  • [X] I have checked the Wiki and Discussions and found no answer

  • [X] I have searched other issues and found no duplicates

  • [X] I want to request a feature or enhancement and not ask a question

Description

What problem are you trying to solve?

Given the following rewrite rules:

|*.services.home.lan|$dnstype=A,dnsrewrite=NOERROR;A;192.168.0.5
|unifi.services.home.lan|$dnstype=A,dnsrewrite=NOERROR;A;192.168.1.2

nslookup unifi.services.home.lan will return both 192.168.1.2 and 192.168.0.5

This behavior is not present when using the Filters > DNS Rewrites functionality.

Proposed solution

Perhaps by specifying a grouping-id to allow only specific rules to apply their records to the rewrite.

Alternatives considered

Or perhaps rewrite rules should only apply their results for the exact same rule match. With more specific rules be preferred over shorter ones.

Additional information

This is undesirable behaviour when the 2 IPs are completely different things, with one being a IP dedicated to a unifi network controller and the other being a general reverse proxy.

ruifung avatar Jan 09 '23 15:01 ruifung