AdGuardHome icon indicating copy to clipboard operation
AdGuardHome copied to clipboard

Cache don't work with labelled device

Open tan-ty opened this issue 2 years ago • 2 comments

Prerequisites

  • [X] I have checked the Wiki and Discussions and found no answer

  • [X] I have searched other issues and found no duplicates

  • [X] I want to report a bug and not ask a question

Operating system type

Linux, Other (please mention the version in the description)

CPU architecture

AMD64

Installation

GitHub releases or script from README

Setup

On one machine

AdGuard Home version

stable 0.107.11

Description

What did you do?

I set a big cache and enable optimistic cache, getting some of my devices labelled.

Expected result

Some requests are stored into cache, and the next time the stored requests come, it'll just response from the cache. And all the devices has separated cache to make edns-client-subnet work better.

Actual result

Those devices who is not labelled work just are using cache as normal, but those labelled don't'

Screenshots (if applicable)

Additional information

tan-ty avatar Sep 01 '22 06:09 tan-ty

Good day. What exactly do you mean by “labelled clients”? Do you mean “persistent clients”? If so, there is a known issue in one of our libraries, AdguardTeam/dnsproxy#169, but that one only concerns clients with custom upstreams.

ainar-g avatar Sep 01 '22 12:09 ainar-g

Good day. What exactly do you mean by “labelled clients”? Do you mean “persistent clients”? If so, there is a known issue in one of our libraries, AdguardTeam/dnsproxy#169, but that one only concerns clients with custom upstreams.

So when will your team fix the bug? I think cache per client is useful and is not too hard to engineer

tan-ty avatar Sep 02 '22 14:09 tan-ty

Closing as duplicate of https://github.com/AdguardTeam/dnsproxy/issues/169.

ainar-g avatar Sep 07 '23 12:09 ainar-g