AdGuardHome icon indicating copy to clipboard operation
AdGuardHome copied to clipboard

Added duplicate rewrite entry check (partially fixes #4585)

Open Bluscream opened this issue 2 years ago • 4 comments

Loop over existing entries and return an error if the entry already exists

Bluscream avatar May 23 '22 19:05 Bluscream

Thank you, but I'd like to put this on hold, since the HTTP API and its code will be fully rewritten during the v0.108 cycle. Also, correct me if I'm wrong, but this won't check for duplicates in the data that is currently being sent?

ainar-g avatar May 24 '22 14:05 ainar-g

This only accounts for sending one single rewrite because the current implementation doesn't work for multiple rewrites. 🤷🏻

Bluscream avatar May 24 '22 21:05 Bluscream

Ah, you're right. I've been thinking ahead of myself :sweat_smile:.

ainar-g avatar May 25 '22 12:05 ainar-g

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Sep 21 '22 03:09 stale[bot]