AdGuardHome icon indicating copy to clipboard operation
AdGuardHome copied to clipboard

Blocked services API: List available services

Open RoboMagus opened this issue 3 years ago • 4 comments

Related to FR #4520

This PR adds GET /blocked_services/services that will return a full list of the service names that can be blocked using the blocked_services API.

It seemed quite easy to implement, though I must declare that I am NOT proficient in Go...

RoboMagus avatar Apr 28 '22 19:04 RoboMagus

Hello and thank you for that contribution! We've actually planned to postpone that until a proper API refactoring that we planned to do later in the v0.108 cycle, but since you've already provided an implementation, we'll try to review your contribution next week. Be aware, though, that when the refactoring comes, it is likely that this API will be rewritten.

ainar-g avatar Apr 29 '22 17:04 ainar-g

Thanks for taking a look into this. It's good to hear that these api changes are already on the roadmap. In that case it might be best to first iron out what the api should look like.

Is there an estimated time frame for when v0.108 is to be released? Cause then I'll postpone work on my integration that interacts with the api until it arrives.

RoboMagus avatar Apr 30 '22 09:04 RoboMagus

@RoboMagus, apologies for the late response. There are no exact deadlines currently, unfortunately. We'll see if we'll be able to fit this into one of the patch releases for the v0.107 branch, but I cannot give any promises on that.

ainar-g avatar Jun 14 '22 13:06 ainar-g

This feature is very much wished for, for the Home Assistant project as well. It would allow us to create switches in Home Assistant to automate on. Right now, we can't, as we can't get a list of services.

frenck avatar Jul 16 '22 14:07 frenck

@RoboMagus, @frenck, we have decided to merge this into v0.107.12. Thank you for the contribution!

ainar-g avatar Aug 25 '22 16:08 ainar-g