AdGuardHome icon indicating copy to clipboard operation
AdGuardHome copied to clipboard

Case-insensitive username check

Open mdawsonuk opened this issue 2 years ago • 4 comments

Resolves #2581 by ensuring that auth checks for the username are performed by doing a lower-case comparison.

A test case was also added in auth_test.go to ensure that the case-insensitive check is correctly performed.

mdawsonuk avatar Mar 26 '22 15:03 mdawsonuk

Codecov Report

Merging #4431 (112d05f) into master (3603b1f) will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #4431   +/-   ##
=======================================
  Coverage   42.53%   42.53%           
=======================================
  Files         100      100           
  Lines       11693    11693           
=======================================
  Hits         4974     4974           
  Misses       6188     6188           
  Partials      531      531           
Impacted Files Coverage Δ
internal/home/auth.go 52.87% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3603b1f...112d05f. Read the comment docs.

codecov-commenter avatar Mar 26 '22 15:03 codecov-commenter

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jul 10 '22 15:07 stale[bot]

Not sure why this is being marked as wontfix

mdawsonuk avatar Jul 12 '22 22:07 mdawsonuk

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Nov 02 '22 03:11 stale[bot]

(For context, see https://github.com/AdguardTeam/AdGuardHome/issues/2581#issuecomment-1359547557.)

ainar-g avatar Dec 20 '22 15:12 ainar-g