AdGuardHome icon indicating copy to clipboard operation
AdGuardHome copied to clipboard
verified publisher icon AdguardTeam

correct openapi schema

Open bakito opened this issue 3 years ago • 3 comments

This PR fixes some issues in the openapi scheme.

  • RemoveUrlRequest is missing property 'whitelist'
  • FilterStatus is missing property 'whitelist_filters'
  • FilterSetUrl property 'data' is set to type Filter instead of inline object
  • 'last_updated' of Filter is not required. At least it comes back as an empty string from the API

It also sets the filter 'last_updated' property to omitempty, to make sure the Filter json and scheme are valid.

bakito avatar Mar 12 '22 11:03 bakito

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jun 12 '22 16:06 stale[bot]

Any update here?

bakito avatar Jun 13 '22 05:06 bakito

Apologies for this slipping through the cracks. We'll try to review it for the next patch release.

ainar-g avatar Jul 22 '22 16:07 ainar-g

Once again, apologies for the long wait. We've made some additional changes and merged the PR. Thanks for the contribution!

ainar-g avatar Aug 17 '22 18:08 ainar-g

Thank you very much

bakito avatar Aug 17 '22 21:08 bakito