AdGuardHome icon indicating copy to clipboard operation
AdGuardHome copied to clipboard

Published 20 hours ago • verified publisher icon AdguardTeam

add cpu temperature

Open Ahmame opened this issue 3 years ago • 6 comments

add cpu temperature and percentage of memory usage

Ahmame avatar Feb 14 '22 20:02 Ahmame

Hello. It seems like there are no changes here? And the release branch must not be merged into master. If you have changes in a branch, could you please make them in a single commit on top of the current master?

Also, it's generally considered good practice to notify the maintainers in an issue before contributing big changes.

Thanks.

ainar-g avatar Feb 15 '22 12:02 ainar-g

anything?

Dynasty-Dev avatar May 26 '22 18:05 Dynasty-Dev

Any idea when your changes will merge on the beta release?

chudasama avatar Jun 13 '22 12:06 chudasama

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Sep 21 '22 03:09 stale[bot]

Hello, any updates?

Dynasty-Dev avatar Sep 21 '22 03:09 Dynasty-Dev

Memory usags would indeed be useful

Bluscream avatar Sep 21 '22 11:09 Bluscream

Any news on this request?

markhecht99 avatar Jun 15 '23 18:06 markhecht99

Any Update on this ? This technology within AGH itself could be very valuable!

Freebase394 avatar Jul 12 '23 19:07 Freebase394

Looks like the base branches on this PR have gotten messed up so this doesn't appear to be in a mergeable state. It's been well over a year, this PR should really be closed.

6twenty avatar Jul 17 '23 05:07 6twenty

Or it should just be fixed and merged so the feature is finally in

Bluscream avatar Jul 17 '23 06:07 Bluscream

There's nothing to fix; OP doesn't even have a public fork of the repo any more, so the branch with the changes is missing. Both the target and base branches on this PR are both internal branches within this repo, and neither of them have anything to do with adding cpu temp and memory info.

6twenty avatar Jul 17 '23 06:07 6twenty

well, if you get food served on a silver plate, eventually it will spoil if you wait long enough 🪦

Bluscream avatar Jul 17 '23 21:07 Bluscream

https://github.com/AdguardTeam/AdGuardHome/pull/4294#issuecomment-1040218646

It seems like there are no changes here?

There was never any food, it's always been a dud PR right from the start.

If anything I strongly suspect that OP meant to create an issue asking for CPU temp and memory usage to be added into AdGuard Home, but mistakenly opened a PR.

6twenty avatar Jul 17 '23 22:07 6twenty

@6twenty is correct. There weren't any discernable changes, and OP hasn't responded since, so closing.

ainar-g avatar Jul 20 '23 11:07 ainar-g