AdGuardHome icon indicating copy to clipboard operation
AdGuardHome copied to clipboard

Manage safesearch for each service

Open ammnt opened this issue 5 years ago • 40 comments

(Updating the top post to summarize the discussion and make sure nothing is lost; original content is under the <details> tag. — @ainar-g)

The way I see it, we'll need the following changes:

  • UI:

    • The single Use Safe Search boolean should be changed into a section of seven booleans:

      • enabled (to enable or disable Safe Search entirely);
      • Bing;
      • DuckDuckGo;
      • Google;
      • Pixabay;
      • Yandex;
      • YouTube;
  • Internals:

    • We should probably finally switch to the lists from the Hostlists Registry, at least in SafeSearch. That means using the same machinery that we already use for dnsrewrite rules.

    • The support for these more fine-tuned settings should be extended to persistent clients as well.

  • Configuration file:

    • The current safesearch_enabled should be replaced by an object containing per-service settings. E.g.:

      safe_search:
          enabled: true
          bing: false
          duckduckgo: true
          google: false
          pixabay: false
          yandex: true
          youtube: false
      
    • The same in the clients.persistent objects.


Original post content

Hello,

it would be great to manage a safesearch for each service separately. Because safesearch for engines disables sites for adults mostly, but for YouTube disables half the content marked as unacceptable for kids. For example, this video is not available in safesearch mode: https://www.youtube.com/watch?v=6YoFkb-LOzg

IMHO this is excessive, but you can only disable it with a safesearch for other services.

Thank you.

ammnt avatar Nov 07 '19 18:11 ammnt

I have the exact same request, definitely want this!

DebrodeD avatar Jan 16 '20 20:01 DebrodeD

I have the same request. I would like to have the SafeSearch feature enabled, but for YouTube it is to much. Thanks!

theovds avatar Apr 02 '20 18:04 theovds

I now disabled SafeSearch, but added DNS rewrites for Google and Bing: www.google.com > forcesafesearch.google.com www.bing.com > strict.bing.com

This works as expected, but it would be nice if this is possible with a GUI option.

theovds avatar Apr 09 '20 18:04 theovds

I now disabled SafeSearch, but added DNS rewrites for Google and Bing: www.google.com > forcesafesearch.google.com www.bing.com > strict.bing.com

This works as expected, but it would be nice if this is possible with a GUI option.

can you walk me through how you did that?

DebrodeD avatar Apr 09 '20 19:04 DebrodeD

Filters -> DNS rewrites -> add these two rewrites there

ameshkov avatar Apr 09 '20 21:04 ameshkov

And also make sure to disable the SafeSearch function at the general settings.

theovds avatar Apr 10 '20 06:04 theovds

I now disabled SafeSearch, but added DNS rewrites for Google and Bing: www.google.com > forcesafesearch.google.com www.bing.com > strict.bing.com

This works as expected, but it would be nice if this is possible with a GUI option.

Of course that won't work. You just type google.co.uk or whatever country tld. Only way to get it to work is do this for all google, bing etc tld's.

rori999 avatar May 12 '20 21:05 rori999

Do we have a timeline when we can get this feature?

nikeshjauhari avatar May 18 '20 15:05 nikeshjauhari

Propose implementation change:

Again, this's only a suggestion. I assume you guys going to display services list (companies names) in UI with toggle button for each. Isn't it good to categorize them instead?

  • Search engines (Google, Bing, Yandex and more)
  • Video platforms (Youtube, Vimeo and more)
  • Image & video sharing sites (Pixelbay, Behance and more)

We can suggest many other safe search available services and i dont see any cons when those under categories.

temporallyaccount avatar Aug 08 '20 05:08 temporallyaccount

@ameshkov is there possible with manual rewrite (temporary measure) to have the switch checked and exclude YouTube only ?

BirdInFire avatar Dec 07 '20 19:12 BirdInFire

@michaelb-ae here are the rewrites you need to add to implement safe search: https://github.com/AdguardTeam/AdGuardHome/blob/master/internal/dnsfilter/safesearch.go#L150

ameshkov avatar Dec 08 '20 20:12 ameshkov

@ameshkov Thanks a lot for this file i had some but not all who is harder to find (yandex)

BirdInFire avatar Dec 08 '20 21:12 BirdInFire

@ameshkov one question (it about safesearch but i don't want to pollute the issue with this simple question), if i enable safe search but do @@ before www.bing.com ,it will force safesearch anyway on bing or don't do it (because it's on allowlist) ?

BirdInFire avatar Dec 18 '20 21:12 BirdInFire

if i enable safe search but do @@ before www.bing.com ,it will force safesearch anyway on bing or don't do it (because it's on allowlist)

Yes, it will force it anyway.

ameshkov avatar Dec 21 '20 10:12 ameshkov

if i enable safe search but do @@ before www.bing.com ,it will force safesearch anyway on bing or don't do it (because it's on allowlist)

Yes, it will force it anyway.

Well, I want to enable safe search, but only disable youtube restricted mode on my local Adguard home DNS server. How can I do that? @ameshkov

stbeep1 avatar Jan 16 '21 14:01 stbeep1

Just as explained in the comments, you can add necessary rewrites manually.

ameshkov avatar Jan 17 '21 11:01 ameshkov

Just as explained in the comments, you can add necessary rewrites manually.

How to edit the rewrites manually? (Only for Youtube)

stbeep1 avatar Jan 17 '21 11:01 stbeep1

@michaelb-ae here are the rewrites you need to add to implement safe search: https://github.com/AdguardTeam/AdGuardHome/blob/master/internal/dnsfilter/safesearch.go#L150

How can I edit this file on my adguard server ? @ameshkov

stbeep1 avatar Jan 17 '21 11:01 stbeep1

Settings -> DNS rewrites -> add rewrites there one by one.

ameshkov avatar Jan 17 '21 11:01 ameshkov

Settings -> DNS rewrites -> add rewrites there one by one.

I know that, but there's is hundreds of url. Any ways to just edit the youtube DNS rewrite? And how? @ameshkov

stbeep1 avatar Jan 17 '21 11:01 stbeep1

It's not efficient to do that. Any workarounds to disable YouTube Restricted mode, but enable Safe search?? @ameshkov

stbeep1 avatar Jan 17 '21 12:01 stbeep1

No, there're no alternatives for now.

ameshkov avatar Jan 17 '21 12:01 ameshkov

What is the normal URL of Youtube. I think I can edit that via DNS rewrites. Is is possible? @ameshkov

stbeep1 avatar Jan 17 '21 12:01 stbeep1

@ameshkov Is any ways to edit "internal/dnsfilter/safesearch.go" or anything similar on my server ?

No, there're no alternatives for now.

stbeep1 avatar Jan 17 '21 12:01 stbeep1

Nope.

You can only fork AdGuard Home, edit it, build your own version.

ameshkov avatar Jan 17 '21 12:01 ameshkov

No, there're no alternatives for now.

Well, do you have a timeline when we can get this feature?

stbeep1 avatar Jan 17 '21 12:01 stbeep1

Planned to v0.107 (may be postponed to v0.108) so I'd say it's Q2 2021

ameshkov avatar Jan 17 '21 12:01 ameshkov

Planned to v0.107 (may be postponed to v0.108) so I'd say it's Q2 2021

@ameshkov We have been waiting for so long, cloud you please release that earlier?

stbeep1 avatar Jan 18 '21 02:01 stbeep1

Any progress on this? It would be nice to see this roll out soon.

GallantChaos avatar May 30 '21 02:05 GallantChaos

I have also recently realized a need for this feature.

As a temporary solution, is there a way to achieve these DNS rewrites on a per client basis?

For example, I have kids devices grouped together by MAC addresses. I would like to have safe search on Google and Bing, but not on YouTube because it is causing more problems for the YouTube Kids app. So I need to exclude YouTube from safe search.

Is there an easy way to achieve this temporarily without affecting adult devices?

WildByDesign avatar Jun 17 '21 11:06 WildByDesign