[BUG] Wrong counting of rules in Safari 16.0 DB2

[peterneutron]

Issue Details

• AdGuard for Safari version: 1.11.6 (216)
• Environment name and version: Safari 16.0 (18614.1.16.11.3)
• Operating System: macOS Ventura 13.0 Beta (22A5286j)
• Filters you use in AdGuard: OISD Basic (https://abp.oisd.nl/basic/)
• Any other browser extensions you have installed: -

Expected Behavior

Custom filters with =< 150k rules get added without error

Actual Behavior

Custom filter with =< 150k rules trigger a warning and counting a negative number

Screenshots

Translation

The limit of 150000 rules has been exceeded. Please disable unnecessary rules to make the app work correctly. Currently enabled rules: 59007 (-90993 rules disabled)

[Birbber]

@introns-bungles Hi! Do you have any other filter enabled except for the mentioned one? Please also share the screenshot of the entire 'Content blockers' tab.

[peterneutron]

@Birbber No, only OISD Basic.

[Birbber]

@introns-bungles Weird. Let's see the logs. Could you please collect them for us?

Here's what we need you to do:

1. Make sure all Safari content blockers are enabled;
2. Reproduce the issue and remember the exact time when it happened;
3. Open the extension settings --> Export logs and system info;
4. Send the archive to [email protected] and mention this issue number and the time of reproduction in the subject.

[peterneutron]

@Birbber Done.

[Versty]

@introns-bungles Thanks! Logs have been received by our devs. Give us some time to work on this issue and I'll be back with an answer.

[peterneutron]

@Versty After installing the latest macOS Developer Beta 13.0 Beta (22A5295h) and Safari 16.0 (18614.1.19.1.5) the issue seems to be resolved.

[Versty]

@introns-bungles Awesome news! In case the issue returns please inform us and reopen this thread.

[yusoofsh]

I'm having this issue 🙏

[peterneutron]

@Versty I can confirm that the issue returned with the jump from macOS 22A5295h -> 22A5295i. Which is very weird because Safari stayed on the same version and I really can't imagine what would possibly cause this bug. But looking at the logs it seems that the rules get converted without a problem. Looks more like an UI Bug.

[Versty]

@introns-bungles @yusoofsh The issue reproduces on our side too and we are currently working on it.

[iDjay]

The annoyance filter doesn't seem to work anymore with the current Safari Beta 16.0 (18614.1.22.1.2)

[Versty]

@iDjay Hi! Thanks for noticing. We are already working on it.

[peterneutron]

@Versty Appears to be fixed with 1.11.7 (220). If others can confirm I think this can be closed.

[Versty]

@peterneutron Currently it is not reproducing on our side either. @yusoofsh Is the issue still persisting on your device?

[yusoofsh]

@Versty Yes. I have the 1.11.7 (219) build from https://agrd.io/safari_beta

[Versty]

@yusoofsh What is your Ventura beta version (?) number currently?

[Versty]

@yusoofsh Also, i would recommend you to temporarily switch from the beta to the release cannel. Please, perform an advanced uninstall and then install the release version from the App Store or from this link.

Follow the steps below to fully uninstall AdGuard for Safari:

1. Uncheck all AdGuard for Safari extensions in Safari -> Preferences -> Extensions (if available)
2. Open Finder and press Shift+Command+G
   • Remove AdGuardSafariApp folder from ~/Library/Application Support directory
   • Remove from ~/Library/Application Scripts - all directories started with com.adguard.safari
   • Remove from ~/Library/Containers - all directories started with AdGuard-
   • Remove TC3Q7MAJXF.com.adguard.safari.AdGuard folder from ~/Library/GroupContainers directory
   • Remove com.adguard.safari.AdGuard.plist from ~/Library/Preferences
3. Open Activity Monitor and force quit all "cfprefsd" processes
4. Remove AdGuard for Safari from Applications

[yusoofsh]

@Versty 13.0 Beta (22A5331f). Also I have followed your instructions, but no luck on my end. It's fine though, not a big deal to me.

[peterneutron]

@Versty Can confirm the issue is back on macOS 13.0 Beta (22A5352e) running Safari 16.1 (18614.2.6.1.1) and the AdGuard for Safari MAS version 1.11.7 (220).

[srcshelton]

@Versty I'm having the same issue on GA macOS 12.6 with Safari Version 16.0 (17614.1.25.9.10, 17614) & AdGuard Version 1.11.7 (220):

There's a title-bar in red stating 'Too many filters enabled. Safari cannot use more than 150000 rules in one group.' and the General -> Content Blockers view shows:

AdGuard Privacy The limit of 150000 rules has been exceeded. Please disable unnecessary rules for the app to work correctly. Enabled rules at the moment: 51802 (disabled rules: -98198) Enabled: AdGuard Tracking Protection filter, EasyPrivacy, Fanboy's Enhanced Tracking List and 4 more

[Brett-Best]

I’m getting this on: macOS 12.6.1 (21G211) Safari Version 16.1 (17614.2.9.1.8, 17614) Safari Technology Preview Release 155 (Safari 16.4, WebKit 17615.1.7.1)

AdGuard Privacy

The limit of 150000 rules has been exceeded. Please disable unnecessary rules for the app to work correctly. Enabled rules at the moment: 51728 (disabled rules: -98272) Enabled: AdGuard Tracking Protection filter, EasyPrivacy, Fanboy's Enhanced Tracking List and 1 more

Be potentially helpful if AdGuard would show how many filters are in each list.

AdGuard Tracking Protection filter (xxx rules)