AdGuardForSafari icon indicating copy to clipboard operation
AdGuardForSafari copied to clipboard

Published 20 hours ago • verified publisher icon AdguardTeam

When opening a large number of tabs in Safari, one of the app's extensions freezes and crash

Open Oleg-Chashko opened this issue 3 years ago • 7 comments

When opening a large number of tabs in Safari, one of the app's extensions freezes und crash. This behavior was noticed in the last beta as well.

Crash and Log: AdGuardForSafariExtension_2021-05-08-134606_MacBook-Pro.crash.zip AdGuardForSafariExtension_2021-05-08-134606-1_MacBook-Pro.crash.zip adg_safari_logs_1620475485795.zip

  1. Sometimes one of the app's extensions freezes in the browser. Bildschirmfoto 2021-05-07 um 22 54 43
  2. When you open an extension in a browser, you can highlight a warning window that the extension is disabled. Bildschirmfoto 2021-05-07 um 22 23 44
  3. As soon as the extension is working again, the warning about the disabled extension disappears. I've seen this happen about 6 times. After updating to v.1.9.14 beta, the condition only got worse!

This behavior has been noticed, even without heavy loads.

Screen_1

Oleg-Chashko avatar May 07 '21 21:05 Oleg-Chashko

Will see what we can do about it.

Birbber avatar May 11 '21 15:05 Birbber

How many tabs need to be opened?

ameshkov avatar May 23 '21 17:05 ameshkov

How many tabs need to be opened?

In about ten minutes, I'm going to cum the test. Unfortunately, it's not just about the number of tabs (It was~100 tabs).

The test will be, without tabs, but with a bad result. Unfortunately it's about the process: com.apple.SafariServices.ExtensionHelper (1443) and AdGuard extension. I'll post a full report in ~20 minutes.

Oleg-Chashko avatar May 23 '21 17:05 Oleg-Chashko

Test:

  1. Safari browser without extensions: No process : (com.apple.SafariServices.ExtensionHelper (1443)), CPU load - OK

https://user-images.githubusercontent.com/62497891/119271145-9160e380-bc00-11eb-9493-1de3226a7721.mp4

  1. Safari browser and with 5 other extensions: No process : (com.apple.SafariServices.ExtensionHelper (1443)), CPU load - OK

https://user-images.githubusercontent.com/62497891/119271252-0f24ef00-bc01-11eb-9a47-10f9e204f6a2.mp4

  1. Safari browser and only with AdGuard extension: Process appeared : (com.apple.SafariServices.ExtensionHelper (1443)), CPU load is very high, Safari Browser to ~ 190%, Process (com.apple.SafariServices.ExtensionHelper (1443) to ~ 160%. You can hear the cooling system working.

https://user-images.githubusercontent.com/62497891/119271520-36c88700-bc02-11eb-82f2-bd42ac689aed.mp4

Somehow it seems to me that and for this, yellow window warning and interface braking when loading, and if you add and tabs, this is what caused the crash.

Oleg-Chashko avatar May 23 '21 18:05 Oleg-Chashko

I forgot to add, the tests were conducted without tabs: (number of tabs 0).

Oleg-Chashko avatar May 23 '21 18:05 Oleg-Chashko

117508929-a21b2380-af89-11eb-96f4-c6a1ce46a2bd This warning can be seen not only when you start the browser, but also later, when you work with the browser. The display duration is ~ 0.5 seconds, this is on mine (2.7 GHz Dual-Core Intel Core i5). You may have more powerful processors, and this display process lasts ~ 0.1 second or less, and you won't see it. And therefore you will not be able to confirm it in your place.

Oleg-Chashko avatar May 23 '21 18:05 Oleg-Chashko

@ameshkov When the "AdGuard" application is not running and Safari is running, click on the application icon. The first menu we see should not be there.

  • Example in the video, it is slowed down ~ 4 times:

https://user-images.githubusercontent.com/62497891/119524413-e8d88e00-bd7d-11eb-8bba-d9b6ff28622d.mp4

Oleg-Chashko avatar May 25 '21 15:05 Oleg-Chashko