Launch AdGuard for Safari at Login doesn't work

[BranchS]

The Launch AdGuard for Safari at Login preference doesn't add AdGuard to the login items list in System Preferences, therefore, it doesn't correctly launch at login, unless I did something wrong.

MacOS Mojave

[BranchS]

Any update on this?

[SuzanXYZ]

Do you mean the fact AdGuard shows "AdGuard does not work. [Turn on]" (I'm paraphrasing)? I see that and have to turn AdGuard on every time I run Safari - if I remember. I still see it even after I turned off "Launch AdGuard for Safari at Login"

[SuzanXYZ]

[ameshkov]

Any update on this?

Sorry, we were a bit too busy with the #114 and weren't looking at the bugs for a while. We'll get back to them now.

[superlex]

Launch AdGuard for Safari at Login doesn't work

It works, but it uses a different system in order to be launched at login (see launchctl list com.adguard.safari.AdGuard.loginhelper for more information), so it doesn't appear under user login items. I don't know if it's better or not, but it works well.

[BranchS]

It doesn't seem to work as well (it didn't work for me until I manually added it to the list), plus there's a lack of user transparency-- it should add itself to that list.

[superlex]

For me it works well but I agree that it would be more transparent if it were added to user login items list.

[ameshkov]

Well, we might need to report it to https://github.com/electron/electron

@Mizzick is there any relevant issue on electron's github?

[Mizzick]

That's what I had found: The most relevant issue https://github.com/electron/electron/issues/7312 tells us that after a long story it had been implemented transparently with user login items addition etc.

But.. after some changes in mac os, I guess in High Sierra, the issue took place https://github.com/electron/electron/issues/10880, and it was fixed with some different way: https://github.com/electron/electron/pull/15010.

So after all this changes, LoginItem API is actually crippled and almost useless for MAS builds. https://github.com/electron/electron/blob/master/docs/api/app.md#appsetloginitemsettingssettings-path-args-macos-windows

[ameshkov]

Well, got it, thanks for the investigation:)

[msanders]

I think this may have been closed by mistake unless there's a more recent issue, this is still extant.

Steps to reproduce:

1. Restart computer, with “Reopen windows when logging back in” unchecked.
2. Open Safari.
3. AdGuard will be paused with a dialog similar to https://github.com/AdguardTeam/AdGuardForSafari/issues/127#issuecomment-465869511

Clicking "Run AdGuard" or manually launching AdGuard for Safari will fix it until the next restart.

"Allow in the Background" is enabled on AdGuard for Safari under Settings > Login Items.