AdGuardForSafari icon indicating copy to clipboard operation
AdGuardForSafari copied to clipboard

Unable to update filters

Open timster opened this issue 6 years ago • 15 comments

I'm unable to update filters on my Mac. I suspect it's because I'm behind a corporate proxy.

Does AdGuard use the system proxy?

Is there a log somewhere that would have more details so I could troubleshoot?

timster avatar Dec 27 '18 22:12 timster

Yep, press alt + command + i to open dev tools and check the console for errors

ameshkov avatar Dec 27 '18 22:12 ameshkov

It didn't show there, but I ran AdGuard from the terminal and it showed more log messages from the electron main process:

~ » /Applications/AdGuard\ for\ Safari.app/Contents/MacOS/AdGuard\ for\ Safari AdGuard\ for\ Safari 
Electron could not be found. No hard resets for you!
2018-12-27T22:17:06.812Z: Application initialization..
2018-12-27T22:17:06.814Z: Starting antibanner service..
2018-12-27T22:17:06.970Z: Initializing toolbar controller..
2018-12-27T22:17:06.971Z: Show preferences callback
2018-12-27T22:17:06.972Z: Initializing toolbar controller ok.
2018-12-27T22:17:07.041Z: Filters metadata loaded
2018-12-27T22:17:07.063Z: Filters i18n metadata loaded
2018-12-27T22:17:07.139Z: Starting loading filter rules from the storage
2018-12-27T22:17:07.323Z: Finished loading filter rules from the storage in 184 ms
2018-12-27T22:17:07.324Z: Starting request filter initialization.
2018-12-27T22:17:07.324Z: Adding rules for filter 2, rules count: 30015
2018-12-27T22:17:07.347Z: Adding rules for filter 3, rules count: 6445
2018-12-27T22:17:07.351Z: Adding rules for filter 10, rules count: 95
2018-12-27T22:17:07.351Z: Adding rules for filter 12, rules count: 687
2018-12-27T22:17:07.351Z: Adding rules for filter 0, rules count: 15
2018-12-27T22:17:07.352Z: Application initialization finished
2018-12-27T22:17:14.033Z: Start checking filters updates..
2018-12-27T22:17:14.033Z: Checking updates for 5 filters
2018-12-27T22:17:14.084Z: Error retrieved response from server for filters [2,3,14,10,12], cause: Error: read ECONNRESET
Stack trace:
Error: read ECONNRESET
    at _errnoException (util.js:1024:11)
    at TLSWrap.onread (net.js:615:25) 

I suspect this is because our proxy re-signs SSL certificates and these are not trusted by AdGuard.

timster avatar Dec 27 '18 22:12 timster

I suspect this is because our proxy re-signs SSL certificates and these are not trusted by AdGuard.

Hm, in theory, AG should trust your certificate if it's added to the system keychain. Do you have it there?

ameshkov avatar Dec 28 '18 07:12 ameshkov

Hm, in theory, AG should trust your certificate if it's added to the system keychain. Do you have it there?

@ameshkov I have a similar problem as OP, but I definitely have the certificate added to the System Keychain. Since the issue is old I'm not sure what version this was reported for, but I'm using 1.5.4 right now.

I can download the filter list manually (https://filters.adtidy.org/extension/chromium/filters/2.txt for example) via Safari or Apple provided curl with no errors (both use the self-signed certificate).

Opening the Developer Tools via command + alt + i and looking at the console I don't see anything, but running it via the Terminal I get this message when trying to update the filters.

16:13:27.358 › Error retrieved response from server for filters [2,3,4,12], cause: Error: self signed certificate in certificate chain
Stack trace:
Error: self signed certificate in certificate chain
    at TLSSocket.onConnectSecure (_tls_wrap.js:1257:34)
    at TLSSocket.emit (events.js:194:13)
    at TLSSocket._finishInit (_tls_wrap.js:734:8)
    at TLSWrap.ssl.onhandshakedone (_tls_wrap.js:566:12)

Also the field for the last update in the App when I try to refresh the lists gets updated despite it actually failing to get any of the lists. If I close and re-open the App it is back to the old date prior to trying to update the filters.

Let me know if there's any other information I can provide or if there's something else I can do/test.

brian-eng avatar Sep 26 '19 20:09 brian-eng

@timster @brian-eng Hello, guys. If it possible, please send us logs. To do this, click on "AdGuard for Safari" on tab bar then select "Export logs and system info.."

SoLenny avatar Jan 28 '20 10:01 SoLenny

@timster @brian-eng any update on the issue?

zzebrum avatar Mar 05 '20 13:03 zzebrum

@zzebrum Still not working for me on version 1.6.4 as I'm guessing MAS will get 1.7.0 eventually.

@SoLenny I've put the contents of the exported logs at least temporarily in this gist

brian-eng avatar Mar 05 '20 18:03 brian-eng

@brian-eng Hello, please try updating the application manually via MAS.

SoLenny avatar Mar 06 '20 09:03 SoLenny

I don't have the problem anymore. Corporate changed the way our proxy works so that may have contributed to the solution.

timster avatar Mar 06 '20 16:03 timster

@brian-eng Hello, please try updating the application manually via MAS.

@SoLenny Done, however 1.7.1 has same symptoms as earlier versions. Namely trying to manually update the filters will update the time, but get a "Filters' update error" notification and not actually update anything. Haven't had AdGuard running long enough to have the automatic updates kick in, but I have no doubt they'd fail as well.

Made a new gist with log information (which looks pretty similar to all the earlier ones) after updating to the latest version.

brian-eng avatar Mar 06 '20 17:03 brian-eng

Sorry that it took us so long to categorize it as a bug, assigned to v1.8

ameshkov avatar Mar 06 '20 18:03 ameshkov

I have exactly the same issue here "trying to manually update the filters will update the time, but get a "Filters' update error" notification and not actually update anything." with v1.11.16.

I assume this issue has not been resolved? Is there any workaround?

Rinfore avatar Dec 07 '23 02:12 Rinfore

@Rinfore To troubleshoot this issue, we need to get the app logs.

Here's what we need you to do:

  1. Make sure all Safari content blockers are enabled;
  2. Reproduce the issue and remember the exact time when it happened;
  3. Open the extension settings --> Export logs and system info;
  4. Send the archive to [email protected] and mention this issue number(115) in the subject.

alexx7311 avatar Dec 07 '23 12:12 alexx7311

Hi @alexx7311, I have send the logs to you. Thanks for the help!

Rinfore avatar Dec 08 '23 00:12 Rinfore

Hi @alexx7311, could I enquire whether there are any updates on this issue? It appears to still be present on Version 1.11.17

Rinfore avatar Mar 19 '24 02:03 Rinfore