AdGuardForSafari icon indicating copy to clipboard operation
AdGuardForSafari copied to clipboard

Can't apply element hiding rule to the element inside IFRAME

Open ameshkov opened this issue 6 years ago • 6 comments

@Alex-302 commented on Sat Sep 09 2017

Original issue https://github.com/AdguardTeam/AdguardFilters/issues/6595#issuecomment-328218629

image

Does not work: t3n-de.cdn.ampproject.org##amp-iframe works: google.de##amp-iframe


@ameshkov commented on Sun Sep 17 2017

The thing is that this is how it is supposed to work in Safari.

if-domain/unless-domain are checked against the window domain, frame domain is ignored.

We can fix this if we use url-filter instead of the if-domain, but it's not good from the performance point of view.

ameshkov avatar Dec 20 '18 12:12 ameshkov

Hi @ameshkov , is this issue only about hiding rules or other ones too? I'm asking that because this fix doesn't work with Safari: https://github.com/easylist/easylist/issues/3916 On the contrary, @@||kataweb.it/wt/wt.js?http$domain=**huffingtonpost.it** works.

superlex avatar Aug 13 '19 11:08 superlex

Yeah, that's about blocking rules (and $domain modifier) as well

ameshkov avatar Aug 13 '19 11:08 ameshkov

Ok, thanks.

superlex avatar Aug 13 '19 13:08 superlex

Hello, any update here? :)

superlex avatar Dec 01 '20 23:12 superlex

Well, not really, that's just how Safari works. We can take another look, but I doubt we'll change much

ameshkov avatar Dec 02 '20 09:12 ameshkov

Ok, thanks anyway :)

superlex avatar Dec 02 '20 13:12 superlex