AdGuardExtra icon indicating copy to clipboard operation
AdGuardExtra copied to clipboard

twitch.tv

Open zloyden opened this issue 3 years ago • 33 comments

https://github.com/AdguardTeam/AdguardFilters/issues/135122 https://github.com/AdguardTeam/AdguardFilters/issues/135722 , especially this https://github.com/AdguardTeam/AdguardFilters/issues/135122#issuecomment-1320942166 (pre-roll before stream). To reproduce this, you should use a European IP, for instance, a German one.

zloyden avatar Nov 22 '22 10:11 zloyden

https://github.com/AdguardTeam/AdguardFilters/issues/135344

zloyden avatar Nov 25 '22 12:11 zloyden

The preroll can be reproduced with a Japanese IP [^1] too.

[^1]: Mullvad VPN

piquark6046 avatar Nov 26 '22 10:11 piquark6046

The pre-roll appears on Twitch backend 1.15.0-twitch.1-rc.1 version for me. Environment: Mozilla Firefox Developer Edition on Desktop, AdGuard Extra (Violentmonkey userscript), AdGuard Base, AdGuard TPF, AdGuard URL Tracking, AdGuard Social, List-KR filter and Mullvad VPN (exit entry: jp-osa-wg-001, multihop mode) Tested with: https://www.twitch.tv/radiyu https://www.twitch.tv/dlddu124 https://www.twitch.tv/flamekr

piquark6046 avatar Nov 29 '22 12:11 piquark6046

The pre-roll appears on Twitch backend 1.15.0-twitch.1-rc.1 version for me. Environment: Mozilla Firefox Developer Edition on Desktop, AdGuard Extra (Violentmonkey userscript), AdGuard Base, AdGuard TPF, AdGuard URL Tracking, AdGuard Social, List-KR filter and Mullvad VPN (exit entry: jp-osa-wg-001, multihop mode) Tested with: https://www.twitch.tv/radiyu https://www.twitch.tv/dlddu124 https://www.twitch.tv/flamekr

Just info, There is also the mid-roll issue that causes the video player to stop buffering, if you trigger it with video player settings change at that time, it will show "commercial break in progress" on video player. Hope you can reproduce this issue too. 👍

Here is video information:

https://user-images.githubusercontent.com/56846906/204666411-2a3312d5-368f-468b-a247-79ef23a985e5.mp4


kodiakhub avatar Nov 29 '22 22:11 kodiakhub

Hope for a quick fix, thank you AdGuard devs. and to all who contribute.

CrazyWolf13 avatar Dec 21 '22 15:12 CrazyWolf13

https://drive.google.com/file/d/1-W71Bs-xbma0XGHrgAN67JqV3vlfS0rj/view Here you can see the ads. But I also noticed that when I play around with the video settings(not in this Video), it also turns on ads. Low latency setting for example.

xGiNT0NiCx avatar Dec 27 '22 15:12 xGiNT0NiCx

@stanislav-atr please also take a look at this with VPN https://github.com/AdguardTeam/AdguardFilters/issues/138550.

zloyden avatar Dec 28 '22 09:12 zloyden

Bypassed.

ghost avatar Feb 17 '23 10:02 ghost

Bypassed.

?

CrazyWolf13 avatar Feb 17 '23 11:02 CrazyWolf13

Any Updates to this ????

xGiNT0NiCx avatar Feb 17 '23 20:02 xGiNT0NiCx

AdGuard Extra: 1.0.506 Chrome v111.0.5563.111

@stanislav-atr pre-roll ads on some streamers:

Video

https://user-images.githubusercontent.com/56846906/227922873-65c70164-4598-46eb-8e09-ffa3259a56f7.mp4

Edit: Also mid-roll ads:

Screenshot

image

kodiakhub avatar Mar 27 '23 11:03 kodiakhub

Hi @stanislav-atr I don't understand, sometimes it shows, sometimes it doesn't. Is Twitch patching too often or is there a similar situation? Can you give information about this? Thanks in advance.

Details

  • Chrome v112.0.5615.87
    • Secure DNS: Cloudflare
  • AdGuard Adblocker v4.1.55
    • AdGuard Base, AdGuard URL tracking, AdGuard Tracking Protection, AdGuard Social media, AdGuard Annoyances, AdGuard Turkish filters.
  • AdGuard Extra v1.0.514
  • Geo: TR

Pre-roll ads show on some streamers but does it not show at other times.

Pre-roll ad video

https://user-images.githubusercontent.com/56846906/232071583-444557e6-f68c-4e60-b47e-ab6ddab82906.mp4

Midrolls ads appears %100 when the streamers advertises manually:

Mid-roll ad video

https://user-images.githubusercontent.com/56846906/232071693-f167fac1-e327-42d4-a5f7-acceb09b852a.mp4

kodiakhub avatar Apr 14 '23 14:04 kodiakhub

https://github.com/AdguardTeam/AdGuardExtra/issues/453 https://github.com/AdguardTeam/AdGuardExtra/issues/422 https://github.com/AdguardTeam/AdGuardExtra/issues/339 https://github.com/AdguardTeam/AdGuardExtra/issues/397

stanislav-atr avatar Aug 02 '23 17:08 stanislav-atr

Looks like this will be never fixed. Is this ticket even in progress?

Morku avatar Aug 09 '23 14:08 Morku

Looks like this will be never fixed. Is this ticket even in progress?

I last posted something in December 2022 and it hasn't been fixed since then...

xGiNT0NiCx avatar Aug 09 '23 14:08 xGiNT0NiCx

Probably not I switched to pi-hole either, works much better

CrazyWolf13 avatar Aug 09 '23 14:08 CrazyWolf13

Looks like this will be never fixed. Is this ticket even in progress?

I last posted something in December 2022 and it hasn't been fixed since then...

I guess under these circumstances the limits are clear or there is some other reason. To me, ads are blocked but from this rest leftovers are problematic. If you are still having issues, there is another solution that you can check here: github.com/younesaassila/ttv-lol-pro (Proxy Method) 👍

kodiakhub avatar Aug 09 '23 14:08 kodiakhub

@Morku @kodiakhub @CrazyWolf13 @xGiNT0NiCx hi! Twitch has been updated for beta version of Extra extension and userscript.

stanislav-atr avatar Aug 30 '23 15:08 stanislav-atr

hi! Twitch has been updated for beta version of Extra extension and userscript.

I will definitely test it and if we see in-video ads or in-video leftovers (Pre-rolls and mid-rolls) to help you better if you let us know what information you want detailed in the report. Otherwise it is difficult to communicate normally like this. 😄 👍

Update: It works flawlessly. @stanislav-atr thanks for your works. 💯

kodiakhub avatar Aug 30 '23 15:08 kodiakhub

While it worked until today perfectly, streams won't start for me since today. Only when I disable Adguard Extra Beta in Firefox, twitch streams start playing.

mrwsl avatar Sep 20 '23 10:09 mrwsl

While it worked until today perfectly, streams won't start for me since today. Only when I disable Adguard Extra Beta in Firefox, twitch streams start playing.

I can confirm, I still see some ads when joining a stream

CrazyWolf13 avatar Sep 20 '23 10:09 CrazyWolf13

While it worked until today perfectly, streams won't start for me since today. Only when I disable Adguard Extra Beta in Firefox, twitch streams start playing.

I can confirm, I still see some ads when joining a stream

On my end, no issues yet in TR with the Chrome v117, AdGuard Adblocker v4.2.168 and AdGuard Extra Beta 1.0.544


Try clearing the browser data related to Twitch may help. Just in case, check that your other third-party filters, extensions and settings do not affect the Twitch etc. If the issue still persists, it may regional and/or A/B testing. 👍

kodiakhub avatar Sep 20 '23 12:09 kodiakhub

Twitch stream still not loading with AdGuard Extra Beta version.

Loads instantly if i disable the Extra Beta.

Nullceptions avatar Sep 20 '23 14:09 Nullceptions

Yeap, Twitch may have updated something on their end because now AdGuardExtra on Firefox appears to completely break Twitch video from loading. Disabling AdGuard Extra on Firefox allows Twitch to continue as expected as @Lust-Ware, @herrwusel, and @CrazyWolf13 mention as well.

So that's a 4/4 confirmation for AdGuardExtra (and Beta) breaking Twitch on Firefox here.

image

goproslowyo avatar Sep 20 '23 19:09 goproslowyo

@goproslowyo @Lust-Ware @CrazyWolf13 @herrwusel Beta version has been tweaked to prevent running Extra if other scripts interfere for cases where Extra is running with desktop AG or uBlock. Looking forward to your feedback.

stanislav-atr avatar Sep 21 '23 12:09 stanislav-atr

@goproslowyo @Lust-Ware @CrazyWolf13 @herrwusel Beta version has been tweaked to prevent running Extra if other scripts interfere for cases where Extra is running with desktop AG or uBlock. Looking forward to your feedback.

That is great, but for now can you add some sort of identification to show when running extra is prevented?

CrazyWolf13 avatar Sep 21 '23 14:09 CrazyWolf13

@stanislav-atr Beta is working again - thanks!

mrwsl avatar Sep 21 '23 16:09 mrwsl

Having issues with this extension again tonight on Chrome with Twitch. Also just tested on FireFox, same result. Video freezes. Tagging @stanislav-atr

zach004 avatar Nov 16 '23 23:11 zach004

I am currently experiencing issues with blocking ads on m.twitch.tv with adguard on Android, I have made a screen recording of the issue here https://streamable.com/v50zr3

I live in Denmark and thus have a Danish IP if that matters.

If I view the site in desktop mode the issue does not seem to persist, however this is not preferable as the player and it's controls are not great for the form factor of a phone.

I will try provide any information that is requested.

PietOlsen avatar Dec 01 '23 10:12 PietOlsen

https://github.com/AdguardTeam/AdGuardExtra/issues/502

jellizaveta avatar Apr 27 '24 13:04 jellizaveta