Barista icon indicating copy to clipboard operation
Barista copied to clipboard

Compile library with API 31

Open IanArb opened this issue 2 years ago • 5 comments

  • Update CameraActivity.kt to handle camera permissions
  • Update CameraTest.java to handle case for deny permission

IanArb avatar Feb 25 '22 10:02 IanArb

Hey @alorma @Sloy I managed to get it compiled against Android 12. However, there are some tests that were failing in previous builds and they are ok running locally. It seems to be trying failing due to the material components. Would this be considered a blocker for this if these tests are not passing? No view matching ((an instance of android.widget.TextView and view.getText() with or without transformation to match: is "Hi! I'm the second screen!" or (view.getParent() is assignable from class <class com.google.android.material.textfield.TextInputLayout> and (view is an instance of android.view.ViewGroup and has descendant matching an instance of android.widget.TextView and view.getText() with or without transformation to match: is "Hi! I'm the second screen!")))) was found

IanArb avatar Mar 01 '22 14:03 IanArb

Hey @alorma @Sloy I managed to get it compiled against Android 12. However, there are some tests that were failing in previous builds and they are ok running locally. It seems to be trying failing due to the material components. Would this be considered a blocker for this if these tests are not passing? No view matching ((an instance of android.widget.TextView and view.getText() with or without transformation to match: is "Hi! I'm the second screen!" or (view.getParent() is assignable from class <class com.google.android.material.textfield.TextInputLayout> and (view is an instance of android.view.ViewGroup and has descendant matching an instance of android.widget.TextView and view.getText() with or without transformation to match: is "Hi! I'm the second screen!")))) was found

If they didn't work on previous versions, it won't be a blocker to this PR. Don't worry! 😆 But feel free to open an issue, now that you've seen which tests didn't pass. Just to know the homework we have to do 😃

About my feedback, it's just a comment. I love having as simpler as possible Activities, so any code we could remove, I love the idea. That's why I think we could leave the CameraActivity as it was if we can, to keep this PR minimal.

rocboronat avatar Mar 02 '22 11:03 rocboronat

Hey @rocboronat I've reverted the camera activity changes and created an issue for the failing tests. https://github.com/AdevintaSpain/Barista/issues/456

IanArb avatar Mar 04 '22 08:03 IanArb

Great! I'll take a last look and merge it. Thannnnks a lot! 😊

rocboronat avatar Mar 04 '22 09:03 rocboronat

Hey @rocboronat I've reverted the camera activity changes and created an issue for the failing tests. #456

Hey @rocboronat any follow up on this review?

IanArb avatar Mar 08 '22 11:03 IanArb

Hi @IanArb .

We've updated the library to API 33.

alorma avatar Dec 04 '22 14:12 alorma