Kuroba
Kuroba copied to clipboard
[Feature] Tap image left or right to go to next image in thread instead of swiping
I have searched the issue list and the app for this but have not found something so I assume this feature isnt present yet.
The context for this feature request is that this feature is in alot of comic reader apps that I use on phone or on the web.
It would go like this: When viewing an image the user can tap on the right part of the image/screen (last 30% of the width?) to go to the next image in the thread. Equivalent for left side of the image to go to the previous one. It would be an optional alternative to the current swipe-left and swipe-right to change images. User could also change the direction and tap location depending if they want it manga style (left->forward) or normal.(right->forward)
This probably conflicts with some current user input tho :/, just thought ill give it a shot.
This is no different than swiping and just adds invisible tap zones that will confuse people that don't know they're there. Swiping works fine. I'll accept a PR however.
It would just be a optional convenience feature then I suppose.
- Is the complexity of implementing this low enough for being a "good first issue"?
- Can you give a little info for people trying to implement this (needed logic thats already implemented somewhere in Kuroba or other suggestions)
I wouldn't really call it a good first issue since it's a bit more complicated than a copy-paste job like most site implementations are (which are the only ones I've got marked as that anyways). You'd need to add in statically sized views to the left/right of controller_image_viewer.xml and add the associated code in to ImageViewerController for the actions associated with them. I suppose you'd also need to add in some settings to ChanSettings and the associated setting location, probably BehaviourSettingsController. You'd also need to disable swiping then at all points in time so that nothing conflicts.