adamant-im icon indicating copy to clipboard operation
adamant-im copied to clipboard

Feat/choose visible wallets

Open RealGoodProgrammer opened this issue 1 year ago • 16 comments

RealGoodProgrammer avatar Dec 14 '23 19:12 RealGoodProgrammer

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
adamant-im ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 7, 2024 6:52pm

vercel[bot] avatar Dec 14 '23 19:12 vercel[bot]

Deployed to https://msg-adamant-pr-570.surge.sh 🚀

github-actions[bot] avatar Dec 14 '23 20:12 github-actions[bot]

Deployed to https://msg-adamant-pr-570.surge.sh 🚀

Re-deployed surge. Now it works @RealGoodProgrammer

bludnic avatar Dec 16 '23 10:12 bludnic

I suggest to simplify names in the Wallets module

actions

setWalletSymbolsTemplates → updateWallets initWalletsSymbolsTemplates →initWallets

getters getAllOrderedWalletSymbols → wallets getVisibleOrderedWalletSymbols → visibleWallets

mutations

setWalletSymbolsTemplates → setWallets

bludnic avatar Jan 04 '24 21:01 bludnic

@RealGoodProgrammer Please merge dev and resolve conflicts. Check remaining review comments.

bludnic avatar Jan 12 '24 15:01 bludnic

@RealGoodProgrammer

How much ADM does a user have on a screenshot? LSK? DOGE?

image
  • Replace three dots ... with ellipsys (a single symbol)
  • Place before the last digit, round it
  • No after . (whole and decimals divider)
  • Show ~ before the number, if you show it not in full

As we discussed with @bludnic, we can round it up to 4 decimals. Otherwise, do the task UI: Balance decimals on Account tab (copied from iOS) https://trello.com/c/Yeh2AR7P fully.

adamant-al avatar Jan 30 '24 16:01 adamant-al

@RealGoodProgrammer Wallet list is empty:

image

adamant-al avatar Feb 01 '24 09:02 adamant-al

Wallet list is empty:

@adamant-al It may be related to the new adamant-wallets structure. @RealGoodProgrammer please merge the dev branch into current

bludnic avatar Feb 01 '24 15:02 bludnic

@bludnic There is still no coins even after merge. Any ideas?

RealGoodProgrammer avatar Feb 03 '24 14:02 RealGoodProgrammer

Rolling back that commit seems solve the issue https://github.com/Adamant-im/adamant-im/pull/570/commits/f72995c1a62f303decbdcda8255279fe96f98b3e Look at the App.vue changes @RealGoodProgrammer

bludnic avatar Feb 03 '24 16:02 bludnic

@RealGoodProgrammer Fix: Update ETH balance and gas price when any of ERC20 coins is active.

adamant-al avatar Feb 03 '24 17:02 adamant-al

@RealGoodProgrammer Merge the dev branch. There are conflicts.

bludnic avatar Feb 11 '24 07:02 bludnic

@RealGoodProgrammer

image

  • Change icon size from 36 to 32
  • Align digits to the right, and a bit bottom
  • For "Blockchain BTC" use regular font-weight, 400 ⟶ 300
  • Ensure that in test account, Chrome ⟶ Mobile ⟶ iPhone SE shows correctly

adamant-al avatar Feb 25 '24 12:02 adamant-al

image

RealGoodProgrammer avatar Feb 28 '24 15:02 RealGoodProgrammer

image

@RealGoodProgrammer Align both lines with numbers to bottom.

adamant-al avatar Feb 29 '24 11:02 adamant-al

@bludnic @martiliones Please review.

adamant-al avatar Feb 29 '24 11:02 adamant-al

@adamant-al , all suggestions has been implemented

RealGoodProgrammer avatar Mar 09 '24 13:03 RealGoodProgrammer

Successfully tore down https://msg-adamant-pr-570.surge.sh 🥲

github-actions[bot] avatar Mar 10 '24 04:03 github-actions[bot]