Adam Williamson comments

Results 433 comments of


                                            Adam Williamson

Docs refer to `Mojo::IOLoop::Delay`, which has been removed in 9.0

Ah, now I poke through a checkout, there's actually quite a lot of code and test code that use `Delay`. So this module is incompatible with Mojo 9.

Use Response instead of BaseResponse

All of these versions of the patch ignore something rather important - `core.py` also does: `from flask import Flask, Response,...` and then later does stuff like `return Response('Invalid status code',...

Fix disabling of location header autocorrect for werkzeug 2+

Closing in favor of #674 , as setting both isn't valid any more (plus this wasn't doing it entirely right).

Incompatibility with werkzeuf 2.1.x (released on 2022-03-28)

I'm wondering if someone needs to fork httpbin at this point. @kennethreitz , are you not interested in keeping it working any more?

Don't emit super-init-not-called for Enum subclasses

This is split out from https://github.com/PyCQA/pylint/pull/7167 , as requested by @DanielNoord .

Don't emit super-init-not-called for Enum subclasses

Uh, I guess that line needs to be changed on main so the bot doesn't add it to every single PR?

Don't emit super-init-not-called for Enum subclasses

@DanielNoord suggests that https://github.com/PyCQA/pylint/pull/7227 would likely avoid the need for this.

Don't emit super-init-not-called for Enum subclasses

No problem. Sorry I didn't get around to writing any tests, have had too many piles of things on fire to deal with :|

Use 3.11 for Github actions

There's an astroid 2.12.1 now, which passes all its own tests on Python 3.11. Current git HEAD dill is good with 3.11, but a release hasn't been tagged yet.

Use 3.11 for Github actions

With a recent snapshot of dill, and astroid 2.12.1, I'm down to 43 failures in the tests when building pylint 2.14.4: https://kojipkgs.fedoraproject.org/work/tasks/1561/89381561/build.log edit: the ones related to deprecated modules/methods are...