Adam Williamson

So I spent a bit of time poking at pychess for Fedora in the last day, but I'm giving up. I have some notes, though! `AttributeError: 'Connection' object has no...

Building on Rawhide (with Python 3.14) has the same seven clearly identifiable errors, but this traceback is also shown multiple times in the output: ``` Traceback (most recent call last):...

As for the `AttributeError: 'ICSStreamReaderProtocol' object has no attribute '_stream_writer'.` problem, that is caused by https://github.com/python/cpython/commit/a355f60b032306651ca27bc53bbb82eb5106ff71 , which landed in 3.13. `ICSStreamReaderProtocol` inherits from `asyncio.StreamReaderProtocol`, and as of that commit,...

ah, hmm, OK, so there's a couple of things going on. I can get 1.0.3 to pass tests on Python 3.14 with just this change: ``` diff --git a/testing/analysis.py b/testing/analysis.py...

I *think* this might fix the FICS problem: ``` --- a/lib/pychess/ic/TimeSeal.py +++ b/lib/pychess/ic/TimeSeal.py @@ -85,8 +85,9 @@ class ICSStreamReaderProtocol(asyncio.StreamReaderProtocol): log.debug(data, extra={"task": (self.name, "raw")}) if self.timeseal: + writer = asyncio.StreamWriter(self._transport, self,...

hmm, a note after more fiddling around: the event loop can actually get leaked across tests run in the same process. Running on 1.0.3 with my patched analysis.py: ``` PYTHONPATH=../lib...

I'm a Fedora QA team member, I try and fix broken Fedora stuff :P I came across this because I was looking at failed image composes, and our games image...

I just did a bisect, and it looks like the failures we're getting with 1.0.5 bisect to 983e138e , "compat.py is not needed from python3.7". That dropped a wrapper around...

Hah. So, I sent a [test PR that bumps the tested Python version to 3.13](https://github.com/pychess/pychess/pull/2359). Two things I learned from that: 1. The tests do fail the same way I'm...

Hah. In fact, the tests are failing even on 3.12, but because your github workflow is broken, you never noticed. Check e.g. https://github.com/pychess/pychess/pull/2357 - all the tests "passed", but if...