Adam Williamson

Results 433 comments of Adam Williamson

OK, in the interests of conservatism, I tweaked this to keep the explicit setting of `continue=` and dropped the baseline to 1.21. We can always bump it higher later.

otherwise does this look good?

well, install pytest-cov or patch pyproject.toml , I guess. Possibly we could drop the `--cov` in pyproject.toml. I copied that over from `setup.cfg` so it's not new, but generally speaking...

oh, yeah, I actually had to remove it in that PR for similar reasons, I think. And it seemed kind of wrong for current standard practices anyway.

we could do something like having `Page.info` as a property with a cache called `Page._info`, it would return `_info` if it existed or populate it and return it if not,...

ugh, that's a shame. This is what I came up with: ``` diff --git a/mwclient/page.py b/mwclient/page.py index e5d9ba5..c62f732 100644 --- a/mwclient/page.py +++ b/mwclient/page.py @@ -13,25 +13,13 @@ class Page: self.site...

oh, well, no, that's not true...if you have a script that does a series of "read page text, edit, read page text, edit, read page text, edit" operations *on a...

So now I have this, which would only result in a refresh on `text()` or `touch()` after a previously non-existent page is edited, a page is moved, or a previously-existent...

oh, yeah, other people exist too. so inconvenient!

if anything this kinda makes me want to just get rid of the `if not self.exists:` shortcuts in `text()` and `touch()`, since we've now got an extensive list of reasons...