Adam Williamson comments

Results 433 comments of


                                            Adam Williamson

[1.0.0] buils fails with Python >= 3.12

https://github.com/drbild/sslpsk/pull/28 looks like it fixes this, also.

Extend test coverage

We're now at 75%. Progress! This is the top of my list of 'do stuff for mwclient' tasks, but I haven't had any time to get to that list lately...

Allow the user to set the "async" parameter when uploading files

Can you please include tests for this? I'm currently trying to get test coverage to 100% and would prefer not to merge any new features without tests. Thanks!

Allow the user to set the "async" parameter when uploading files

also, you could probably just squash all the changes into one commit.

Allow the user to set the "async" parameter when uploading files

I would also expect a test that asserts this works as expected, e.g. by mocking out `handle_api_result` and checking it is called with the expected args. Of course the code...

Allow the user to set the "async" parameter when uploading files

Agreed with @marcfrederick . Thanks for all your work on this.

Allow the user to set the "async" parameter when uploading files

I'd prefer a single squashed commit.

Unarchive the flathub repo

Also, the current build is based on org.kde.Platform 6.6, which is EOL. this causes warnings when doing `flatpak update` and is also flagged on flathub. can it be rebuilt on...

rename `reqs` arg to `connection_options` (#197)

Any thoughts on this before I merge it? @mwclient/maintainers

It has been [hardcoded to True and deprecated upstream since mediawiki 1.32](https://gerrit.wikimedia.org/r/c/mediawiki/core/+/392542/10/includes/api/ApiQuerySiteinfo.php), and upstream briefly removed it, which broke all mwclient code: https://phabricator.wikimedia.org/T371977 . So we [took out use of...