Adam Williamson

Results 433 comments of Adam Williamson

oh, yeah, hmm, I see...there are even a couple of places (`random` and `exturlusage` at least) where we pass a specific value which looks like we're expecting it to work...

Sure. We could also call it something like 0.90.0 to make it clear it's an RC, but I'm bikeshedding :) Would also shake out any non-obvious issues in the new...

So, there are more complications! We have two large PRs that sort of conflict: https://github.com/mwclient/mwclient/pull/336 adds type annotations to the entire codebase, https://github.com/mwclient/mwclient/pull/299 adds user management (but doesn't have type...

sure, strictly speaking that makes sense, I guess it's just that anything that touches every file in the project (more or less) "feels" like a 1.0 change to me! But...

OK, I'll send a PR for my first idea then and we can see what folks think of that. I *think* it's kinda the 'safest' approach.

OK, so we merged the limit thing, and it would be good to get the writeapi fix out. @mwclient/maintainers , does anyone have an objection to doing a 0.11.0 release...

https://github.com/mwclient/mwclient/pull/332 is a follow-up to document `clientlogin`.

edit: nope, I was wrong, I think marc's right...

I kinda preferred how the existing file has OAuth *first*. We really want to encourage people to use OAuth for what's probably the most common use case (connecting to wikimedia...

Should we also document `clientlogin()`?