Adam Williamson

Results 433 comments of Adam Williamson

Couple of notes: 1. the typing here is weird, but I've left it as-is. `_parse_disksize` returns a string, before and after this patch. But the `generate_diskimage` methods and `_internal_generate_diskimage` implicitly...

ImageFactory PR: https://github.com/redhat-imaging/imagefactory/pull/458

FWIW, I'm also working on a PR that fixes a few problems, gets the test suite (and hence oz itself) working on Python 3.12, and - hopefully - a github...

hmm, I think this failure might actually be a real one! looking into it.

yaaay. The change to the XML schema is probably a bit more permissive than it should be, but, you know, regexes. i don't want to make it too complicated. It...

[This scratch build](https://koji.fedoraproject.org/koji/taskinfo?taskID=112376177) was done with size set to `16GB` and worked. We did realize we need a [change to Koji too](https://pagure.io/koji/pull-request/3989#), though.

BTW, to resolve the licensing concern, Richard said the function is too trivial to be copyrightable.

just to make things clearer, I've moved the CI fixes to https://github.com/clalancette/oz/pull/314 . that means CI fails on this PR now, but with 314 merged it would pass again.

We don't necessarily need it merged upstream, though. ;) In fact, the builders have it already, as part of [this update](https://bodhi.fedoraproject.org/updates/FEDORA-2024-b07eef6bc8). What we don't have yet is a patched Koji,...

hey again! @waldyrious looped me into helping out with maintaining mwclient since dan is inactive ATM. I'm looking through old pull requests, obviously this one is pretty large and will...