AndroidAppTemplate icon indicating copy to clipboard operation
AndroidAppTemplate copied to clipboard

Proposal: Contribution to Refactoring Codebase to Gradle Convention Plugin

Open VahidGarousi opened this issue 1 year ago • 6 comments

Hello! I'm interested in contributing to the project titled 'Refactoring Codebase to Gradle Convention Plugin: Enhancing Build Efficiency and Maintainability.' I've reviewed the project's goals, I believe I can make valuable contributions to this effort.

Before I start working on any changes, I wanted to discuss this with you to ensure my contributions align with the project's goals and roadmap. I'd appreciate any guidance or information you can provide to get started.

Looking forward to your feedback!

VahidGarousi avatar Sep 21 '23 11:09 VahidGarousi

@AdamMc331 did you read this issue?

VahidGarousi avatar Oct 06 '23 09:10 VahidGarousi

Can you share some resources on this plugin you're referring to?

AdamMc331 avatar Nov 05 '23 00:11 AdamMc331

https://github.com/Kaaveh/ComposeNews/tree/kmp/build-logic

Mastering Dependency Management: Version Catalog & Convention Plugin at Scale 🚀 https://medium.com/proandroiddev/mastering-android-dependency-management-b94205595f6b

VahidGarousi avatar Nov 05 '23 05:11 VahidGarousi

@VahidGarousi Thanks for sharing! I'm open to changes in this template, but I want to understand a little more about what specifically we're changing. For example, this project already uses Gradle Version Catalogs.

So I think the suggestion here is specifically the Gradle Convention Plugin, which is helpful if this project were to scale up to multiple modules as we could reduce boilerplate across different modules?

AdamMc331 avatar Nov 05 '23 18:11 AdamMc331

@AdamMc331 Yes, you're correct! The Gradle Convention Plugin can be beneficial for this project, especially if you plan to scale up to multiple modules. It helps reduce boilerplate code across different modules by applying consistent conventions. It allows you to define common configurations and settings in one place, making it easier to manage and maintain this project as it grows. This approach enhances consistency and streamlines the development process across modules.

VahidGarousi avatar Nov 05 '23 18:11 VahidGarousi

That makes sense! I'm not super familiar with it, if you'd like to make a PR we can discuss it more then!

AdamMc331 avatar Nov 06 '23 03:11 AdamMc331