snapping_sheet icon indicating copy to clipboard operation
snapping_sheet copied to clipboard

Published 20 hours ago • verified publisher icon AdamJonsson

feat: make SnappingSheetController listenable

Open TheOneWithTheBraid opened this issue 3 years ago • 4 comments

This allows to listen for position changes of the SnappingSheetController. Might be useful e.g. to transform or animcate the sheet's content based on the current position.

The Listenable overrides are forwarded to the ValueNotifier inside the _SnappingSheetState.

  • implement Listenable in SnappingSheetController
  • use ValueNotifier for current position

Signed-off-by: TheOneWithTheBraid [email protected]

TheOneWithTheBraid avatar Apr 02 '22 13:04 TheOneWithTheBraid

Do you have any pending review issues? Could you merge?

TheOneWithTheBraid avatar Apr 30 '22 06:04 TheOneWithTheBraid

I would appreciate if you could merge this. In case you are looking for maintainers for the project, please communicate this.

We'd otherwise publish a fork on pub.dev as we do not want to permanently rely on git imports.

TheOneWithTheBraid avatar May 19 '22 09:05 TheOneWithTheBraid

@AdamJonsson Could you merge this? It is not such a big change. Otherwise, please tell me what to fix.

TheOneWithTheBraid avatar May 30 '22 09:05 TheOneWithTheBraid

@AdamJonsson Could you please merge this?

TheOneWithTheBraid avatar Jun 07 '22 13:06 TheOneWithTheBraid