Adam Wójcik comments

Results 1119 comments of


                                            Adam Wójcik

Update `spfx project azuredevops pipeline add` and `spfx project github workflow add` commands to add support for federated Identity

> Also: I feel like federatedIdentity should become the default. The only question is if we consider that a breaking change. It might be, but in this area of creating...

Update `spfx project azuredevops pipeline add` and `spfx project github workflow add` commands to add support for federated Identity

yes, we may take up this issue even now. Just not make this default behavior but when some option is defined

Update `spfx project azuredevops pipeline add` and `spfx project github workflow add` commands to add support for federated Identity

@milanholemans , @waldekmastykarz , @martinlingstuyl I think we missed the opportunity to implement this. I haven't looked at this issue for a while since I have a related PR opened...

Update `spfx project azuredevops pipeline add` and `spfx project github workflow add` to work with any version of SPFx

> What should we do if an SPFx version supports multiple versions of Node? We can't just randomly pick one, right? Should we prompt it to the user? good question....

Update `spfx project azuredevops pipeline add` and `spfx project github workflow add` to work with any version of SPFx

> I think it's not up to us to decide which Node version to use. Maybe the user has a perfect reason not to use the latest Node version because...

Update `spfx project azuredevops pipeline add` and `spfx project github workflow add` to work with any version of SPFx

@pnp/cli-for-microsoft-365-maintainers any other feed on this one or can we open it up?

Update `spfx project azuredevops pipeline add` and `spfx project github workflow add` to work with any version of SPFx

I'll work on that

Extend: `spo site add` command with Brand center option

> Maybe we should just enhance `spo site add` with the possibility of adding a brand center. When the type brandCenter is picked, we can still show a prompt. This...

Extend: `spo site add` command with Brand center option

> [@Jwaegebaert](https://github.com/Jwaegebaert) [@Adam-it](https://github.com/Adam-it) [@milanholemans](https://github.com/milanholemans), why can't we include both options? We can extract the site creation code and reuse it for different scenarios: a regular site, a Brand Center site...

Extend: `spo site add` command with Brand center option

@pnp/cli-for-microsoft-365-maintainers I think this issue has become a bit stale and we only need to decide for the approach. I think we all agreed that we rather not add a...