Adam Wójcik

Results 1119 comments of Adam Wójcik

One comment from my side which we already talked about internally is that we could reuse a lot of code from the `app add` command się we may move some...

> Also we could wait a bit for that improvement #5870 Pointed out by @martinlingstuyl. Currently this is the last thing not covered yet > > Since we don't call...

yep. I would also not wait for this feature if you are ready to go 🚀. I would: 1. look for similarities with the `app add` command and extract that...

@milanholemans since the implementation kinda started already maybe we should just open it up. @MathijsVerbeeck would you like to take the lead on this on and may I assign you...

seems like another huge refactor is on the way 😅. good suggestion. Let's do some research 📚💪

Had one more check (I hope final) on the implementation: - I like the fact we moved the telemetry outside of the command it seems a huge plus. BUT does...

> @MartinM85 awesome work 👏🤩 We are getting a lot closer. Let's do another round before we move forward. > > One thing I noticed is the additional scopes we...

Ready to merge 🚀

merged manually 👏

- besides the usual naming and support for site-relative URL - why don't we want to use `retainInheritedPermissions` as well? - any reason why in the scope we don't allow...