Adam Wójcik
>Nice discussion, I'm joining in late. But better late than never! What should I say then 😅. Needed some time to re-read this all ... like twice 😋. I feel...
>Love the design @waldekmastykarz! Initially I was a little confused with the use of the # char but your comment in the constructor makes it very clear. I had the...
@martinlingstuyl I think those files (npm-shrinkwrap and package.json) are actually present in the PR because @Jwaegebaert added those two new packages 🤔🙂
Thanks for the quick update on this one. I hope I will review it over the weekend 👍
@Jwaegebaert we are getting really close 🤩🤩 Please double check my last review or lets wait for @waldekmastykarz or @garrytrinder to leave a comment about the `xml2js` package 👍
@Jwaegebaert I reviewed and tested it locally.. seems ok. I got only last two small improvements we might add: - validation between end and start date - more readable output...
> I'll leave the merging to you. You put a lot of effort in this PR so you should also be mentiond within the commit 😄 no problem for me...
@Jwaegebaert looks good to me. Will have a final check and will try to merge this one next week 👍
will merge today during night. still got one other PR to double check, but this one is for sure to be merged ✔
merged manually