Adam Lewis
Adam Lewis
- [ ] ~We should probably disallow taints on the general node since nothing will work correctly and it'd be a lot of work to fix that and no has...
- [x] make sure this PR won't break if using `existing` provider or `local` providers
- [ ] ~~During upgrade, we'll need to add taints to each of the node groups listed or else the users will get an error during deployment.~~ Update: this is...
Okay, I think things are working on AWS. I resolved some issues on Azure, but still need to test Azure.
I tested on GCP, Azure, and AWS and works well on all. I did the following in my test: - Created an admin user - launched a dask cluster -...
- [x] I want to create an issue at least to prompt users on upgrade to ask if they want to add the taints for potential cost reductions. Update: done...
We should add some instructions to the docs about adding other node groups (e.g. gpus). Users should add the user taint to other user node profiles in order to prevent...
Rather than making the user make sure to put a consistent taint on each node group, maybe we should just have a "type" field on node groups to simplify this....
Okay, this PR is ready for review!
> Hi, @Adam-D-Lewis. Were the changes we discussed last week applied? Regardingng the default taints and overrides? Yes, they were in [this commit](https://github.com/nebari-dev/nebari/pull/2605/commits/747a2933b5d32b02d18d16c2a1b866e1ee6280aa). See the `set_missing_taints_to_default_taints` method as a starting...