RecordFlux icon indicating copy to clipboard operation
RecordFlux copied to clipboard

IP options specification incomplete

Open rssen opened this issue 4 years ago • 2 comments

There is no support for an option "x00" (which is a valid option "End of Option List" according to RFC 791 p. 16). This is used at the end of all options, not the end of each option, and need only be used if the end of the options would not otherwise coincide with the end of the internet header.

ipv4.rflx:

Option_Number : Option_Number
            then null
               if Option_Class = Control and Option_Number = 1,
            then Option_Length
               if Option_Number > 1;

            what if Option_Number = 0?

This problem occurred while rewriting the spark tests for python. (Method Test_Parsing_IPv4_With_Options in rflx_ipv4_tests.adb).

rssen avatar Mar 27 '20 13:03 rssen

Sequences with end marker are not yet supported (#61). Therefore the test case mentioned above (Test_Parsing_IPv4_With_Options) is currently disabled.

treiher avatar Mar 27 '20 14:03 treiher

Moved to https://github.com/Componolit/RecordFlux-specifications/issues/6.

treiher avatar Oct 30 '20 16:10 treiher