rebar3_format icon indicating copy to clipboard operation
rebar3_format copied to clipboard

Test suite doesn't properly run on Windows

Open ElectronicRU opened this issue 3 years ago • 5 comments

erlfmt_formatter_SUITE and sr_formatter_SUITE, which both derive path to test_app from code:priv_dir, fail on Windows, because there it points to _build/test/rebar3_format/priv. I imagine it has something to do with Windows not doing the symlink thing.

This isn't high priority, obviously, but maybe changing the derivation to use __FILE__ could be done.

ElectronicRU avatar Jun 08 '21 06:06 ElectronicRU

Hi @ElectronicRU … Sadly, none of the current maintainers have Windows here. Would be willing to consider becoming an external collaborator for this project and helping us with that, and any other things you would like to help with, of course? 🙏🏻

elbrujohalcon avatar Jun 08 '21 08:06 elbrujohalcon

@elbrujohalcon sure thing, so long as you can offer some assistance setting up appropriate CI - it'd take me an unreasonably long time to figure out GitHub's workings of it for such a small change, and I already spent enough figuring GitLab's out ^^"

ElectronicRU avatar Jun 08 '21 08:06 ElectronicRU

I'm not the CI-guy here… but… I know who can help!!

@paulo-ferraz-oliveira can I use your github-actions expertise yet once more for this project? 🙏🏻

elbrujohalcon avatar Jun 08 '21 09:06 elbrujohalcon

@ElectronicRU … you should have a github invitation in your email :)

elbrujohalcon avatar Jun 08 '21 09:06 elbrujohalcon

Let me try... You want to CI over Windows, right? There's yet no available (that I know of) proper GHA for Windows over OTP 24, but we can work with 23 until either erlef/setup-beam or gleam-lang/setup-erlang get updated.

paulo-ferraz-oliveira avatar Jun 08 '21 09:06 paulo-ferraz-oliveira