hologram
hologram copied to clipboard
Does `hologram me` need a separate protocol message?
I was just dealing with the client/server portion of the code and noticed that the handling for hologram me
is almost identical to hologram use
, except that it assumes the default role. Could the client/server portion be simplified by unifying the messages and logic processing them?
Absolutely!
One of the things on my radar was to simplify that part of the code, and that's one of the main candidates :)
Looks like the AssumeRole message has both user and role as optional, so it should be fairly easy to change the code to send an AssumeRole message with empty role as a result of hologram me
and the server using the default role for it.
hologram me
vs. hologram use
was a distinction back when we were using both AssumeRole
and GetSessionToken
on the STS API. Since it's just AssumeRole
now, yeah, we should only have one protocol message.