hologram icon indicating copy to clipboard operation
hologram copied to clipboard

Does `hologram me` need a separate protocol message?

Open copumpkin opened this issue 9 years ago • 2 comments

I was just dealing with the client/server portion of the code and noticed that the handling for hologram me is almost identical to hologram use, except that it assumes the default role. Could the client/server portion be simplified by unifying the messages and logic processing them?

copumpkin avatar Apr 01 '15 16:04 copumpkin

Absolutely!

One of the things on my radar was to simplify that part of the code, and that's one of the main candidates :)

Looks like the AssumeRole message has both user and role as optional, so it should be fairly easy to change the code to send an AssumeRole message with empty role as a result of hologram me and the server using the default role for it.

frangarciam avatar Apr 01 '15 17:04 frangarciam

hologram me vs. hologram use was a distinction back when we were using both AssumeRole and GetSessionToken on the STS API. Since it's just AssumeRole now, yeah, we should only have one protocol message.

epall avatar Apr 22 '15 00:04 epall