Multiple Fixes & GoDoc Descriptions

Open rmenn opened this issue 11 years ago • 3 comments

Fixed a couple of bugs that i myself created. Added Description for godoc Added VpcId to Create Security Group so that SGs can be created within VPC.

Please Review.

Thanks

Dec 10 '14 09:12 rmenn

If all Good, Can close #135

Dec 10 '14 10:12 rmenn

Thanks @rmenn Does it make sense to keep the signature for CreateSecurityGroup intact and add another function like CreateSecurityGroupInVPC
Although we don't have a guideline for this, I feel uncomfortable about this. and "traditionally" people have added functionality by keeping the old functions and adding new ones.
Soon we need to sit down and plan a next major release and cleanup all of these.

Dec 10 '14 10:12 alimoeeny

Makes Sense, Let me redo that.

Dec 11 '14 02:12 rmenn