baker icon indicating copy to clipboard operation
baker copied to clipboard

Implementing a new config QueueNames to sqs Input.

Open danimaribeiro opened this issue 1 year ago • 1 comments

Queue prefixes could lead to undesired behaviour, this new option makes the use strict to specific queues

:question: What

Implementing a new config QueueNames to sqs Input. When using deadletter queues in SQS we often do not expect Baker to read from that queue, but because the default is to add the suffix to the queue name to indicate is a dead-letter queue, Baker ends up reading from that queue too.

With this new parameter we are strict to which queues we want to read from without surprises if some queue with similar name is created.

:hammer: How to test

Change the QueuePrefixes parameter to QueueNames - it should behave the same way, but it will listen only to that specific queue.

:white_check_mark: Checklists

This section contains a list of checklists for common uses, please delete the checklists that are useless for your current use case (or add another checklist if your use case isn't covered yet).

  • [X] Is there unit/integration test coverage for all new and/or changed functionality added in this PR?
  • [ ] Have the changes in this PR been functionally tested?
  • [X] Have new components been added to the related all.go files?
  • [X] Have new components been added to the documentation website?
  • [X] Has make gofmt-write been run on the code?
  • [X] Has make govet been run on the code? Has the code been fixed accordingly to the output?
  • [X] Have the changes been added to the CHANGELOG.md file?
  • [X] Have the steps in CONTRIBUTING.md been followed to update a Go module?

danimaribeiro avatar Sep 28 '22 19:09 danimaribeiro

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Sep 28 '22 19:09 CLAassistant