BetterGen icon indicating copy to clipboard operation
BetterGen copied to clipboard

Published 20 hours ago • verified publisher icon Ad5001

Switching to Minecraft PC Loot tables

Open Thunder33345 opened this issue 7 years ago • 18 comments

Basically title; having a similar or same system as mojang current loot table works

The conditions section could get ignored but some basics would be nice

wiki: http://minecraft.gamepedia.com/Loot_table#Tags

low priority but good to take note of and sorted when other higher things get done

Thunder33345 avatar May 09 '17 10:05 Thunder33345

https://github.com/ClearSkyTeam/PocketMine-MP/commit/6ef9e616f9b14a8eff1155e567725d85af9ebadf

Loot table generation/randomisation proven to work here.

This could be imported to this plugin.

inxomnyaa avatar May 09 '17 10:05 inxomnyaa

Table gen: https://github.com/ClearSkyTeam/PocketMine-MP/blob/6ef9e616f9b14a8eff1155e567725d85af9ebadf/src/pocketmine/utils/TempLootGenerator.php loot tables: https://github.com/ClearSkyTeam/PocketMine-MP/blob/6ef9e616f9b14a8eff1155e567725d85af9ebadf/src/pocketmine/resources/loot_tables/gameplay/fishing.json https://github.com/ClearSkyTeam/PocketMine-MP/blob/6ef9e616f9b14a8eff1155e567725d85af9ebadf/src/pocketmine/resources/loot_tables/gameplay/fishing/fish.json https://github.com/ClearSkyTeam/PocketMine-MP/blob/6ef9e616f9b14a8eff1155e567725d85af9ebadf/src/pocketmine/resources/loot_tables/gameplay/fishing/junk.json

Thunder33345 avatar May 09 '17 13:05 Thunder33345

Those loot tables are actually taken from the MCPE default addon.

inxomnyaa avatar May 09 '17 15:05 inxomnyaa

Btw am I allowed to take this code and adapt it or not?

Ad5001 avatar May 09 '17 15:05 Ad5001

This could be imported to this plugin

inxomnyaa avatar May 09 '17 15:05 inxomnyaa

Btw am I allowed to take this code and adapt it or not?

i dont see anything stopping you like it's already open sourced but i advise you not to copy it directly due to how it's meant only for fishing with bunch of hotfixes love the usage of projects FINALLY... Someone used it

Thunder33345 avatar May 09 '17 16:05 Thunder33345

They are pretty useful by using issues ;)

Ad5001 avatar May 09 '17 17:05 Ad5001

cough assign me

inxomnyaa avatar May 13 '17 17:05 inxomnyaa

@thebigsmileXD Well, I can't until you accept the colaboration.

Ad5001 avatar May 13 '17 18:05 Ad5001

Oh xd i forgot that this is needed

inxomnyaa avatar May 13 '17 20:05 inxomnyaa

@thebigsmileXD Btw when you start working on an issue, Move it in the projects tab ;)

Ad5001 avatar May 13 '17 21:05 Ad5001

kk

inxomnyaa avatar May 13 '17 21:05 inxomnyaa

image

inxomnyaa avatar May 14 '17 08:05 inxomnyaa

image See the loottables branch

inxomnyaa avatar May 14 '17 09:05 inxomnyaa

try to close only after it's merged pull #22 is not merged

Thunder33345 avatar May 14 '17 15:05 Thunder33345

the problem is the legal part eula and shit

inxomnyaa avatar May 14 '17 15:05 inxomnyaa

image This might take some fucking time

inxomnyaa avatar May 16 '17 10:05 inxomnyaa

Nope, fuck this. I will not go through every fucking file and remake all changes

@Ad5001 DIY.

inxomnyaa avatar May 16 '17 10:05 inxomnyaa