aw-watcher-window icon indicating copy to clipboard operation
aw-watcher-window copied to clipboard

RFC: add gnome-shell compatibility

Open FlorianLudwig opened this issue 4 years ago • 8 comments

Add gnome-shell specific way of getting current window. Allows the watcher to work on wayland.

This is gnome-shell specific and won't work on any other wayland based compositor and therefor does not solve #18

The poetry.lock needs updating but I have to figure out how to do it without updating all libs and just add the new dependency.

As this features requires a new dependency and is specific to one OS with one desktop environment, I marked that dependency as optional. Especially since it requires system libs to be installed to function, increasing the overall footprint quite a bit on non GNOME systems.

FlorianLudwig avatar Jun 10 '20 13:06 FlorianLudwig

This pull request introduces 1 alert when merging e9c4f3d9166bcefa19dadabd60de5a25bb07a474 into fbec7ed00e60619753aa0170026a73178dc6f72d - view on LGTM.com

new alerts:

  • 1 for First parameter of a method is not named 'self'

lgtm-com[bot] avatar Jun 10 '20 14:06 lgtm-com[bot]

Is there any progress on this? I would be glad to start using this on GNOME wayland as I getting tired of useless reports from rescuetime (where I do not expect this will be ever implemented).

Jakuje avatar Aug 06 '20 15:08 Jakuje

@jakuje Unfortunately there's no progress as you can see.

If it important for you to use Wayland it is possible to use aw-watcher-window-wayland but that does not work on gnome due to it not implementing the wlr-foreign-toplevel-management Wayland protocol.

Otherwise the status is the same as before, we'd like to avoid merging this if possible because it's gnome specific rather than Linux/Wayland specific, but if we have no option in the future we might merge it anyway.

johan-bjareholt avatar Aug 06 '20 15:08 johan-bjareholt

You

rickdub2011 avatar Nov 07 '20 12:11 rickdub2011

Any further thoughts on this request?

jacksongoode avatar May 31 '21 09:05 jacksongoode

This no longer works with GNOME 41 that restricts Eval. There is a workaround (https://github.com/ramottamado/eval-gjs) but packaging _aw_current_window as a Shell extension seems to be now the best alternative.

jopereira avatar Nov 14 '21 11:11 jopereira

FYI, https://extensions.gnome.org/extension/4974/window-calls-extended/ might already provide the info you need

sgraf812 avatar Dec 18 '22 18:12 sgraf812

Thanks @sgraf812, based on the information here I was able to put together a primitive activity logging shell script for gnome+wayland, you can see it at https://github.com/JohannesBuchner/activitytracker/blob/master/track-gnome.sh

JohannesBuchner avatar Dec 09 '23 10:12 JohannesBuchner