aw-watcher-web icon indicating copy to clipboard operation
aw-watcher-web copied to clipboard

add safari support,tested and is working

Open bugparty opened this issue 7 months ago • 5 comments

[!IMPORTANT] Add Safari support to the web extension, including build, manifest, and documentation updates.

  • Build System:
    • Adds build-safari job to .github/workflows/build.yml for building Safari extension on macOS.
    • Updates Makefile with build-safari, update-safari, and zip-build-safari targets.
    • Adds test-reproducibility-safari target to Makefile.
  • Manifest and Permissions:
    • Updates src/manifest.json to include Safari-specific fields and permissions.
  • Consent Handling:
    • Modifies src/consent/main.ts to conditionally uninstall extension only if not Safari.
  • Documentation:
    • Updates README.md with instructions for building and enabling the Safari extension.
    • Adds Safari option to browser selection in src/settings/index.html.

This description was created by Ellipsis for add8fb08e589b0d8ae0c592ce46886cf66e20d45. You can customize this summary. It will automatically update as commits are pushed.

bugparty avatar May 16 '25 22:05 bugparty

it seems the Xcode template copied some resources from the build folder

bugparty avatar May 16 '25 23:05 bugparty

hummm, I will add readme instruction and the CI workflow.not a big deal for me.

bugparty avatar May 16 '25 23:05 bugparty

Great! Just one suggestion — when you’ll be setting up the CI, you might want to generate all the necessary files directly in the pipeline. This will help keep everything up to date with the source code and prevent duplication across different parts of the project :)

BelKed avatar May 16 '25 23:05 BelKed

Okay, I will do that

bugparty avatar May 16 '25 23:05 bugparty

@BelKed Hi, I finished all the requirements,please check, for the ci, check here https://github.com/bugparty/aw-watcher-web-safari/actions/runs/15083040913 another question is what do you guys expects when the ci build is finished, do you wish to upload the built safari extension ?

bugparty avatar May 17 '25 07:05 bugparty

can this get merged so there can be an official safari extension?

djdanielsson avatar Jul 01 '25 01:07 djdanielsson

Could you guys merge this? would be great to have it!

ninafiona avatar Aug 28 '25 13:08 ninafiona