activitywatch icon indicating copy to clipboard operation
activitywatch copied to clipboard

Improve import result message interface

Open rakleed opened this issue 6 years ago • 5 comments

Feature requests on the forum

Is your feature request related to a problem? Please describe. Upon successful import, a null message is displayed, which is very difficult to associate with a successful import. And if import fails, the message {"message": "Internal Server Error"} is displayed all the time, which also does not say what the problem is.

Describe the solution you'd like If import is successful, the message Import completed successfully! is displayed. And if import fails, a message is displayed that the import could not be completed, and the specific reason why (and also its solution is possible).

Describe alternatives you've considered

Additional context The server should give the correct error messages, which can be displayed in the web interface to the user.

rakleed avatar Mar 25 '20 18:03 rakleed

Good catch, been thinking about this before but never opened an issue. We'll implement this in aw-server-rust, which is destined to become the default server soon™.

ErikBjare avatar Mar 26 '20 08:03 ErikBjare

@ErikBjare The datastore actually already returns the exact error in aw-server-rust, it's just a matter of sending it in the HTTP body response.

johan-bjareholt avatar Mar 26 '20 10:03 johan-bjareholt

This would be slightly more complex (for a minor issue), but it would be great to stay on the same page, and instead just get the HTTP response in a box/alert that you can then close

nicolae-stroncea avatar Jun 26 '20 04:06 nicolae-stroncea

This would be slightly more complex (for a minor issue), but it would be great to stay on the same page, and instead just get the HTTP response in a box/alert that you can then close

This is now in progress here:

https://github.com/ActivityWatch/aw-webui/pull/210

Next step is to return the actual error from aw-server and make the alert show that message, then we can consider this issue to be fixed. Right now it only says "Importing failed, see aw-server logs for more info"

johan-bjareholt avatar Jun 27 '20 20:06 johan-bjareholt

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Dec 24 '20 20:12 stale[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jun 23 '21 01:06 stale[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jun 28 '22 00:06 stale[bot]