Activiti
Added condition to check that a Task owns a variable before we set it…
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.
@gonzalocamarero look that the PR cannot be merged.. you probably need to rebase the code in order to add your commit on top of the last commit into the branch. If the PR is not green we usually cannot merge it. Also I notice that the PR is not including any test, and that is a problem, because we cannot validate that you are not breaking any other functionality with your addition.
@salaboy Ok, I will try to do the test, and upload a correct PR, sorry!
@gonzalocamarero should we close this one? or are you still working in a test for it? Notice that you will need to rebase it now
Please, close it, I can't do the right test by now. When I can, I try to do it by the correct way (with test and correct tag/version). Sorry!
El jue., 22 nov. 2018 a las 12:41, salaboy ([email protected]) escribió:
@gonzalocamarero https://github.com/gonzalocamarero should we close this one? or are you still working in a test for it? Notice that you will need to rebase it now
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Activiti/Activiti/pull/2122#issuecomment-441004321, or mute the thread https://github.com/notifications/unsubscribe-auth/AAx3JisiVlmSx_RlGujGub-Mf26P6Amcks5uxo1ogaJpZM4YO2K4 .