FrogFind icon indicating copy to clipboard operation
FrogFind copied to clipboard

Published 20 hours ago • verified publisher icon ActionRetro

Fix hrefs that had single quotes

Open lazd opened this issue 2 years ago • 4 comments

This PR fixes instances where attribute values were quoted with single quotes. Netscape 1.12 doesn't like this, and this was resulting in all links to be broken.

I imagine this originally happened because of PHP's nice variable interpolation feature when double quotes are used (i.e. "Hi my name is $name"), but most instances used the string concatenation operator (.), so I just kept them as-is instead of trying to get fancy and escape chars.

I couldn't test this as I don't have a PHP environment running locally, but it should work!

Fixes #5

lazd avatar Nov 02 '22 02:11 lazd

This fix looks good to me. @ActionRetro are you able to merge this and deploy to frogfind.com?

lukecyca avatar Mar 11 '23 21:03 lukecyca

Let's get this merged!

lazd avatar May 13 '23 17:05 lazd

@lazd This branch has a few small conflicts after #21 got merged, but that's only because this branch includes some fixes in files that now no longer exist (left-over files of the 68k.news project that were in here too). If you were to pull in the latest from main and accept that these files have been deleted now, this branch should be A-OK for getting merged again when Mister ActionRetro has a chance to take a peek!

jibsaramnim avatar Aug 15 '23 01:08 jibsaramnim

Thanks @jibsaramnim, it's up to date now!

lazd avatar Aug 15 '23 15:08 lazd