krita-ai-diffusion icon indicating copy to clipboard operation
krita-ai-diffusion copied to clipboard
verified publisher icon Acly

Magcache Support

Open dseditor opened this issue 5 months ago • 2 comments

Added support for MagCache. It has been tested locally link (custom server) with ComfyUI. MagCache is commonly used in video models such as FramePack and Wan, and it also supports models like Flux and Flux Kontext. This support includes updates to nodes and adjustments to detailed parameters.

https://github.com/Zehong-Ma/ComfyUI-MagCache

dseditor avatar Jul 09 '25 13:07 dseditor

Looks interesting.

I have two requests:

  1. Show only one button (enable/disable) OR one slider (strength). I don't think all the parameters should be exposed, unless there is a good reason to tweak them for certain scenarios. Default values for the models can be passed to the node.
  2. There should be no need for PerformanceSettings in workflow.py? The parameter is already part of CheckpointInput. Please handle MagCache in the existing load_checkpoint_with_lora function (similar to WaveSpeed), don't introduce a new one.

Acly avatar Jul 12 '25 12:07 Acly

Thanks for Acly's detailed review. I'll try to address these issues. I think we might keep a threshold setting to accommodate models that will use MagCache in the future, but clean up unnecessary code

dseditor avatar Jul 13 '25 15:07 dseditor