aclify icon indicating copy to clipboard operation
aclify copied to clipboard

default parameter to the middleware fn

Open Amgad-Atef-Mohamed opened this issue 4 years ago • 0 comments

@eiabea @marklawlor @rimiti https://github.com/Aclify/aclify/blob/ffed05930d77b6f48f8117a42797086163fefb37/src/classes/acl.ts#L470

I think this condition wrong when anyone uses the middleware without sending the permissions parameter.

https://github.com/Aclify/aclify/blob/ffed05930d77b6f48f8117a42797086163fefb37/src/classes/acl.ts#L468 also, this condition wrong when anyone uses the middleware without sending the number of Paths parameter.

Redis storage take the second parameter as a string with is the prefix but in the readme example take an object // Using Redis store const acl = new Aclify.Acl(new Aclify.RedisStore(RedisClient, {prefix: 'acl_'}));

so it must be:

const acl = new Aclify.Acl(new Aclify.RedisStore(RedisClient,'acl' }));

Amgad-Atef-Mohamed avatar Jan 11 '21 09:01 Amgad-Atef-Mohamed