nvim-trevJ.lua icon indicating copy to clipboard operation
nvim-trevJ.lua copied to clipboard

Adds support for more sophisticated argument lists and ruby blocks

Open willfish opened this issue 1 year ago • 5 comments

What

  • [x] Adds support for custom handlers which support more idiomatic/custom reverse joining behaviour
  • [x] Adds support for blocks and do_blocks reverse joins
  • [x] Adds more sophisticated support for ruby argument_lists
  • [x] Extract ruby-specific-behaviour into a dedicated container file

Why

  • I use this plugin and its predecessor a lot in some ruby projects I maintain
  • I assumed you'd be okay with separate files for dedicated language support to avoid cluttering the standard implementation with custom handlers

willfish avatar Mar 04 '23 22:03 willfish

Hi @willfish! This looks nice, I'm been quite busy lately and haven't gotten around to this yet but it's on my todo :)

AckslD avatar Mar 07 '23 15:03 AckslD

Hi @AckslD . No biggie, I'm using it in earnest at work just to see if I can't find any bugs. I've noticed a couple:

  • blocks (basically anonymous functions you pass to methods) get removed when revjing on argument_lists of method calls with blocks attached
  • revjing in a method chain works for everything but the first method argument_list

Thanks for putting this project together :pray:

willfish avatar Mar 07 '23 16:03 willfish

@willfish, sorry again for taking ages for this, I should have prioritised it higher. I think it looks good and would be happy to merge if you still would like to.

AckslD avatar Apr 08 '23 02:04 AckslD

No worries @AckslD. I'll reopen this a bit later :pray:

willfish avatar Apr 11 '23 07:04 willfish

Great! Would you mind resolving the conflicts? :)

AckslD avatar Apr 11 '23 14:04 AckslD