agm-overlays icon indicating copy to clipboard operation
agm-overlays copied to clipboard

Published 20 hours ago • verified publisher icon AckerApple

Angular 9 ng build --prod error

Open silverio opened this issue 5 years ago • 8 comments

Hi,

I recently updated my app to angular 9 and it works fine with ng serve, but when I try to build it with ng build --prod I get the following error: ERROR in node_modules/agm-overlays/AgmOverlays.module.d.ts:1:22 - error NG6002: Appears in the NgModule.imports of MapPageModule, but could not be resolved to an NgModule class any idea on how to resolve this issue?

silverio avatar Feb 07 '20 18:02 silverio

Historically Angular releases a breaking version and it breaks dependencies. And then the package, aka dependency, and then adopters complain it no longer works with their version.

It’s a crazy game we play with Angular.

This package most likely just needs to be built with Angular 9 now

AckerApple avatar Feb 07 '20 19:02 AckerApple

@AckerApple thanks for your open source effort and I do feel your pain. Having said that, the ng team has been releasing ng9 betas for a long time. We have a huge list of dependencies, I had issues with many of them but when I upgraded to the latest version the issues went away. Right now the only dependency that prevents us from building with ng 9 is this project. My team would appreciate your attention to this as soon as feasible with your schedule.

gae123 avatar Feb 07 '20 21:02 gae123

I just bundled my other popular library, angular-file, using Angular 9 with Ivy turned on. It looks like a success but I JUST released it, version 3.0.0, minutes ago.

I will attempt to do the same thing to this library coming soon. I have two other Angular libraries, same thing. So I hear the need, a bit rather busy though.

AckerApple avatar Feb 08 '20 22:02 AckerApple

Success! Someone reported already reported success with my other package upgrade to Angular 9

This package, now version 2.0.0, is built on Angular 9. This version of Angular, 9, sure does build faster and smaller.

Marking issue as ready to close

AckerApple avatar Feb 09 '20 15:02 AckerApple

@AckerApple Could you publish a changelog for 2.0.0?

fpeterdev avatar Feb 20 '20 15:02 fpeterdev

Naaaaaaa, I don’t use this code in anyway and so I updated just Angular version is all just for y’all

AckerApple avatar Feb 20 '20 21:02 AckerApple

what about an update to angular 10?

guybmayor avatar Oct 11 '20 13:10 guybmayor

We could totally do that. I had a PR on angular-file for someone wanting Angular 10 support enough to make a PR for it and I accepted.

If you’d like to make a PR for this package to support NG10 please help. Otherwise I will get to it relatively soon. One man band here

AckerApple avatar Oct 11 '20 17:10 AckerApple