sfmc-devtools
sfmc-devtools copied to clipboard
98 rewrite util to static classes to improve intelli sense (outline)
PR details
What is the purpose of this pull request? (put an "X" next to an item)
Please delete options that are not relevant.
- [x] Other, please explain: rewrite util to static classes to improve intelli sense
What changes did you make? (Give an overview)
set the the methods in util as static, in file.js separated the js library from the Files class, rewrote all instances where fs methods were called using File.
Is there anything you'd like reviewers to focus on?
- eslint gave some warnings, those were fixed by setting the "parserOptions": { "ecmaVersion": "latest" }, as seen here
- in File, module.export only the class files. and not both {...Files, ...fs} as it wasn't working with the static class. the fs library is declared separably. as commented here
Checklist
- [x] I have performed a self-review of my own code