sfmc-devtools
sfmc-devtools copied to clipboard
Task/294 task run checkproperties on config load
PR details
What is the purpose of this pull request?
- [X] Other, please explain: Internal
What changes did you make? (Give an overview)
rework loading parameters logic into a new class to help reduce circular dependencies and remove bloat in common classes
Is there anything you'd like reviewers to focus on?
initial stab - feedback requested more generally about approach
Checklist
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] ESLint & Prettier are not outputting errors or warnings
- [ ] README.md updated (if applicable)
- [ ] CHANGELOG.md updated
- [ ] ran
npm run docs
to update developer docs
Wrong target? ;)
moving this out of 4.0.0. it's a waste of time at this point. suggesting to re-do the PR only with the purpose of reducing file system reads which is actually a great idea.
but without changing the error-recognition & reporting logic (exception vs boolean return)