adop-platform-management icon indicating copy to clipboard operation
adop-platform-management copied to clipboard

Published 20 hours ago • verified publisher icon Accenture

Toggle LDAP/ACL

Open RobertNorthard opened this issue 7 years ago • 4 comments

As a platform user, I want to be able to toggle ACL.

This is dependent on ADOP_ACL_ENABLED environment variable for adop-docker-compose for Jenkins.

Dependent on;

  • ~~https://github.com/Accenture/adop-jenkins/pull/35~~
  • ~~https://github.com/Accenture/adop-docker-compose/pull/194~~
  • Load platform job that executes on a master to read the Jenkins global rather than system environment variables.

RobertNorthard avatar Feb 23 '17 12:02 RobertNorthard

I'm wondering if we should flip the logic in the interest of backwards compatibility? If someone is on an older version of the Jenkins image they won't have the environment variables which means the jobs will be generated with sections missing and it won't be obvious why.

nickdgriffin avatar Feb 27 '17 21:02 nickdgriffin

PR submitted for Load_Platform to read global variables instead of environment variables:

  • https://github.com/Accenture/adop-jenkins/pull/37

Going to test ACL/LDAP toggling.

ghost avatar Feb 28 '17 14:02 ghost

I have tested the following scenarios.

  • [x] ADOP ACL and LDAP enabled environment variables set to true.
  • [x] ADOP ACL set to false and LDAP true.
  • [x] ADOP LDAP set to false and ACL false.
  • [x] ADOP LDAP/ACL set to false.

The ADOP LDAP environment variable is set in the adop-docker-compose for Jenkins.

This PR can be merged on it's own.

RobertNorthard avatar Mar 08 '17 12:03 RobertNorthard

@SachinKSingh28 I've merged Maris changes so this will need another review.

RobertNorthard avatar Nov 15 '17 10:11 RobertNorthard