Review weight & benchmarks.

[xlc]

https://github.com/AcalaNetwork/Acala/blob/2da9f5e704f9010b7ba836aa6700fc4e0996a932/modules/homa-lite/src/lib.rs#L248

The weight for on_idle clearly related to number of matches, which is not considered here.

Will also need review all other benchmarks.

[ferrell-code]

Tracking issue for Benchmark audit:

• [ ] Homa-lite
  • [ ] mint & mint_for_requests
• [x] Dex
  • [x] swap_with_exact_target & swap_with_exact_supply (#1588)
• [x] StakingPool
  • [x] on_initialize (known issue has a todo)
• [x] Honzon (#1597)
  • [x] close_loan_has_debit_by_dex
• [x] CdpEngine (#1609)
  • [x] liquidate
• [x] CdpTreasury (#1609)
  • [x] auction collateral
  • [ ] OnFinalize hook needs weight in on_initialize
• [x] AuctionManager
• [x] CollatorSelection
• [ ] Currencies
  • [ ] benchmarks need to account for erc20 tokens
• [x] EmergencyShutdown
• [x] TransactionPayment
• [x] TransactionPause
• [x] SessionManager
• [x] Prices
• [x] Nft
• [x] Incentives
• [ ] IdleScheduler
  • [ ] idle scheduler makes assumption that 1 extra write will be relatively cheap to the dispatched calls (likely to be true but not always)
• [x] Evm (#1627)
• [x] EvmAccounts

orml:

• [x] Auction
• [x] Authority
• [x] Oracle
• [ ] Tokens
  • [ ] dusting does not correctly accounts for evm stuff (check other pallets for this as well)
• [x] Vesting