rez icon indicating copy to clipboard operation
rez copied to clipboard

Use forward slashes in PowerShell

Open anderslanglands opened this issue 3 years ago • 3 comments

PowerShell consumes forward slashes in path names just fine. CMake occasionally barfs on backslashes. Therefore this PR just uses forward slashes for pwsh and everything is happy.

anderslanglands avatar Jul 24 '22 08:07 anderslanglands

CLA Signed

The committers listed above are authorized under a signed CLA.

  • :white_check_mark: login: anderslanglands / name: Anders Langlands (0a9f16930df7143116370567fd13b44f8926e3ec, 03257cb8dc3ec1d6d1f3c9ad8c22d31d2f2a4640)

Previous PR, for context: https://github.com/AcademySoftwareFoundation/rez/pull/1273

Considering that CMake apparently misbehaves even in Windows with proper, normalized paths, I'd rather normalization be an explicit, opt-in feature so that projects that require this custom behavior can still have it and the default, expected behavior still functions as expected. This PR doesn't give the user any option to opt-in / opt-out of the change. What if something else other than CMake needs backslashes? etc.

ColinKennedy avatar Jul 24 '22 15:07 ColinKennedy

Hey Anders,

Please see the discussion in https://github.com/AcademySoftwareFoundation/rez/issues/1302 as I think this really is the root of the issue. Feel free to add to that thread, it needs to be picked up again. But yes this stuff does need to be fixed, I just think we need to do so in a more general way (as this is not a powershell specific thing).

nerdvegas avatar Jul 24 '22 23:07 nerdvegas